Bug 1832752: Monitoring silence form time tests #5327
Conversation
Start time should default to the current time and the end time should be 2h from now.
The end time was being calculated based on the start time even if the start time was invalid.
openshift-ci-robot
added
the
approved
kyoto
changed the title
openshift-ci-robot
added
bugzilla/severity-low
|
@kyoto: This pull request references Bugzilla bug 1832752, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -1318,7 +1319,7 @@ const SilenceForm_: React.FC<SilenceFormProps> = ({ defaults, Info, title }) => | |||
| const [createdBy, setCreatedBy] = React.useState(defaults.createdBy ?? ''); | |||
| const [duration, setDuration] = React.useState(defaultDuration); | |||
| const [endsAt, setEndsAt] = React.useState( | |||
| defaults.endsAt ?? formatDate(new Date(now.setHours(now.getHours() + 2))), | |||
| defaults.endsAt ?? formatDate(new Date(new Date(now).setHours(now.getHours() + 2))), | |||
There was a problem hiding this comment.
Working with dates in JS is still silly. 🙄
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, dtaylor113, kyoto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@kyoto: All pull requests linked via external trackers have merged: openshift/console#5327. Bugzilla bug 1832752 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes 2 silence form bugs and adds e2e tests for the form's time inputs.