New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1833411: Add README for OCS Plugin #5330
Conversation
@bipuladh you have not added bugzilla |
@bipuladh: This pull request references Bugzilla bug 1833411, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@bipuladh: This pull request references Bugzilla bug 1833411, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bipuladh, Can we also add on how to add a new flag for a new feature coming from backend in annotation?
Following table maps the annotation to its use case and accepted values: | ||
|Annotation Name|Purpose|Accepted Values | | ||
|------------------------------------------------|---------------------------|--------| | ||
| `features.ocs.openshift.io/enabled`| Activate UI Features | "external", "snapshot" | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `features.ocs.openshift.io/enabled`| Activate UI Features | "external", "snapshot" | | |
| `features.ocs.openshift.io/enabled`| Supported features from OCS backend | Array of supported features | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You pass these to activate the console features.
/bugzilla refresh |
@bipuladh: This pull request references Bugzilla bug 1833411, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, cloudbehl, gnehapk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bipuladh: All pull requests linked via external trackers have merged: openshift/console#5330. Bugzilla bug 1833411 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.