New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1830095: Update Control Plane status logic to include no. of not healthy compo… #5344
Bug 1830095: Update Control Plane status logic to include no. of not healthy compo… #5344
Conversation
@rawagner: This pull request references Bugzilla bug 1830095, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rawagner: This pull request references Bugzilla bug 1830095, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
I think those conditions for One small detail if the layout works okay would be writing
kind of sounds like 1 Control Plane is degraded, which is a little odd. "Operators" being plural makes the wording there a little different. |
18455a8
to
692b688
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you, LGTM!
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andybraren, mareklibra, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rawagner: All pull requests linked via external trackers have merged: openshift/console#5344. Bugzilla bug 1830095 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ments
@andybraren
If data fetching from Prometheus failed we show
x not available
If there are no data ->
x unknown
If the success rate is low ->
x degraded
Does that make sense ? Do you think its worth having not available and unknown status here ? We already have that for Operators health.