Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1829869: Add confirmation step when toggling from yaml to form during operand creation #5361

Merged
merged 1 commit into from May 13, 2020
Merged

Bug 1829869: Add confirmation step when toggling from yaml to form during operand creation #5361

merged 1 commit into from May 13, 2020

Conversation

TheRealJon
Copy link
Member

Add a confirmation step when toggling to the form view if YAML data will be lost.

screenshot-localhost_9000-2020 05 06-10_32_12

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 8, 2020
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: This pull request references Bugzilla bug 1829869, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1829869: Add confirmation step to create operand yaml to form view toggle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the component/shared Related to console-shared label May 8, 2020
@TheRealJon
Copy link
Member Author

/assign @benjaminapetersen

@TheRealJon TheRealJon changed the title Bug 1829869: Add confirmation step to create operand yaml to form view toggle Bug 1829869: Add confirmation step when toggling from yaml to form during operand creation May 8, 2020
dtaylor113
dtaylor113 approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than small nit comment, lgtm

rhamilto
rhamilto reviewed May 11, 2020
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One CSS nit and a second of Dave's comment about including type.

frontend/packages/console-shared/src/components/synced-editor/styles.scss Outdated Show resolved Hide resolved
@TheRealJon TheRealJon requested a review from rhamilto May 11, 2020 20:57
benjaminapetersen
benjaminapetersen approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, dtaylor113, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2020
@openshift-merge-robot openshift-merge-robot merged commit f46e60f into openshift:master May 13, 2020
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: All pull requests linked via external trackers have merged: openshift/console#5361. Bugzilla bug 1829869 has been moved to the MODIFIED state.

In response to this:

Bug 1829869: Add confirmation step when toggling from yaml to form during operand creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone May 18, 2020
@TheRealJon TheRealJon deleted the 1829869-bz branch January 28, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

@dtaylor113 dtaylor113 dtaylor113 approved these changes

@spadgett spadgett Awaiting requested review from spadgett

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@benjaminapetersen benjaminapetersen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@TheRealJon @openshift-ci-robot @benjaminapetersen @rhamilto @spadgett @dtaylor113 @openshift-merge-robot