Bug 1830121: Enable pod list to display node instead of owner

[rhamilto]

and enable for daemon sets, jobs, replica sets, replication controllers, and stateful sets

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1830121

[openshift-ci-robot]

@rhamilto: This pull request references Bugzilla bug 1830121, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

[WIP] Bug 1830121: Change daemon set pod list to display node instead of owner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@rhamilto: This pull request references Bugzilla bug 1830121, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

[WIP] Bug 1830121: Change daemon set pod list to display node instead of owner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhamilto]

/retest

[TheRealJon]

@rhamilto I don't mind this solution too much, but I would prefer to use redux instead of passing the prop down through all of the intermediate components. PodTableRow is already connected to redux, so it shouldn't be too difficult to hook something up there. We just need to make sure to unset that state when we leave the pages that use it. Should be easy enough to set up a hook to do that as well. The only other thing I would say is that maybe we could name the useAltTable prop to something a little bit more descriptive?

In the long run, it would be nice if we came up with a way to handle this using a bit of logic. We can figure out if the current resource owns all the pods on the Pods tab using owner references and the uid of the currently viewed resource. That being said, I think a solution like that might blow up the scope of this PR, so I'd be fine with a solution that uses redux as above.

[spadgett]

We should be able to use the existing customData prop to pass down any additional data without adding a new prop.

[rhamilto]

Take 2 using customData, which I now remember @spadgett mentioning before. SMH ;-)

[rhamilto]

Note: I intend to squash commits, but wanted to confirm we want the change for Jobs, ReplicaSets, and StatefulSets.

[TheRealJon]

/lgtm

[rhamilto]

Note: I intend to squash commits, but wanted to confirm we want the change for Jobs, ReplicaSets, and StatefulSets.

What about ReplicationControllers, too?

[spadgett]

I think it makes sense to add Replication Controllers here as well.

We want to see the owner for Deployments, Deployment Configs, and Cron Jobs. I see you've left out those resources, which is probably right.

It would be nice to hide the Namespace column, but we can make that a separate change.

[openshift-ci-robot]

@rhamilto: This pull request references Bugzilla bug 1830121, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1830121: Enable pod list to display node instead of owner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[TheRealJon]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@rhamilto: All pull requests linked via external trackers have merged: openshift/console#5368. Bugzilla bug 1830121 has been moved to the MODIFIED state.

In response to this:

Bug 1830121: Enable pod list to display node instead of owner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.