New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1834486: Make empty state page for topology list/graph consistent #5397
Bug 1834486: Make empty state page for topology list/graph consistent #5397
Conversation
@jeff-phillips-18: An error was encountered adding this pull request to the external tracker bugs for bug 1834486 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@jeff-phillips-18: This pull request references Bugzilla bug 1834486, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks for doing this @jeff-phillips-18
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18, rohitkrai03, serenamarie125 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jeff-phillips-18: All pull requests linked via external trackers have merged: openshift/console#5397. Bugzilla bug 1834486 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-3658
Analysis / Root cause:
List view for topology was showing the same empty state as the admin project workloads view.
Solution Description:
Update the empty state view for the topology list view to be the same view as the graph's view.
Screen shots / Gifs for design review:
List View:
Graph View:
Admin project workloads view:
(minor change to remove the
group by
andfilter
controls when empty @beanh66 )Browser conformance:
cc @openshift/team-devconsole-ux @serenamarie125 @beaumorley @beanh66
/kind bug