Bug 1834945: Add sticky footer to PipelineBuilderForm #5415

divyanshiGupta · 2020-05-12T18:03:53Z

Fixes: https://issues.redhat.com/browse/ODC-3742

Screenshot:

/kind bug

openshift-ci-robot · 2020-05-12T18:03:59Z

@divyanshiGupta: This pull request references Bugzilla bug 1834945, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1834945: Add sticky footer to PipelineBuilderForm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andrewballantyne

We lost the static sidebar. You can now scroll away from the full-sidebar.

openshift-ci-robot · 2020-05-13T08:49:45Z

@divyanshiGupta: This pull request references Bugzilla bug 1834945, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1834945: Add sticky footer to PipelineBuilderForm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andrewballantyne

Nit and an unexpected style. But otherwise looking good.

...tend/packages/dev-console/src/components/pipelines/pipeline-builder/PipelineBuilderForm.scss

andrewballantyne · 2020-05-15T22:43:56Z

...tend/packages/dev-console/src/components/pipelines/pipeline-builder/PipelineBuilderPage.scss

@@ -1,4 +1,5 @@
 .odc-pipeline-builder-page {
  height: 100%;
  position: relative;
+  overflow-x: hidden;


What is this getting around? Horizontal overflow shouldn't really ever need to be explicitly mentioned if I did my job with the layout 😄

@andrewballantyne I added this to avoid

Interesting. I'll have to look to reproduce that. Did you zoom in? The bubble looks cut off.

Yes, see if you can reproduce it. No I didn't zoom in.

I cannot reproduce this. 🤔 You look to be using Chrome... is this on Linux? What version of Chrome?

Yes I am using Chrome. Yup on linux.
@andrewballantyne just to be sure you tried to reproduce this after removing the overflow property, right? 😅 . If yes then it might be because of my display settings probably.

Haha yes I did. I also tried several zoom features to try and reproduce the unbalance of the node. I think there is definitely something happening here with an upscale to your UI. I think it would be useful for us to determine what that is... even the icons for the "+" buttons look off.

Yeah then its because of my display settings, I keep my scaling factor to 1.25 :P.

So even with scaling factor set to 1 I still see this 🤔

Interesting. Maybe this is just another reason for us to convert the node to SVG (from a foreignObject div usage)

andrewballantyne

I don't see anything inherently wrong with the overflow styles. But I do want to investigate the origins of needing it @divyanshiGupta

I'm going to get this merged asap but we should definitely circle back to how you're having these issues. It looks subpar on styling and mechanics from your gif.

/lgtm
/retest

openshift-ci-robot · 2020-05-19T18:32:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, divyanshiGupta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/dev-console/OWNERS~~ [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-05-19T19:44:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-19T20:49:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-20T00:30:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-20T01:09:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-05-20T03:45:53Z

@divyanshiGupta: All pull requests linked via external trackers have merged: openshift/console#5415. Bugzilla bug 1834945 has been moved to the MODIFIED state.

In response to this:

Bug 1834945: Add sticky footer to PipelineBuilderForm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels May 12, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console labels May 12, 2020

openshift-ci-robot requested review from nemesis09 and vikram-raj May 12, 2020 18:04

divyanshiGupta force-pushed the jira-issue#3742 branch 2 times, most recently from 364e519 to 44c1413 Compare May 12, 2020 18:11

andrewballantyne suggested changes May 12, 2020

View reviewed changes

openshift-ci-robot assigned andrewballantyne May 12, 2020

divyanshiGupta force-pushed the jira-issue#3742 branch from 44c1413 to 6b1b9a8 Compare May 15, 2020 13:32

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2020

divyanshiGupta requested a review from andrewballantyne May 15, 2020 13:32

divyanshiGupta force-pushed the jira-issue#3742 branch from 6b1b9a8 to 64de5a6 Compare May 15, 2020 13:36

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2020

divyanshiGupta force-pushed the jira-issue#3742 branch from 64de5a6 to 85ff5b2 Compare May 15, 2020 13:42

andrewballantyne suggested changes May 15, 2020

View reviewed changes

divyanshiGupta force-pushed the jira-issue#3742 branch from 85ff5b2 to 7d40380 Compare May 19, 2020 13:13

Add sticky footer to pipeline builder form

7d40380

andrewballantyne approved these changes May 19, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2020

openshift-merge-robot merged commit 5a09960 into openshift:master May 20, 2020

spadgett added this to the v4.5 milestone May 22, 2020

andrewballantyne mentioned this pull request May 26, 2020

Bug 1840137: Fix the Pipeline Builder sidebar required asterisk #5559

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1834945: Add sticky footer to PipelineBuilderForm #5415

Bug 1834945: Add sticky footer to PipelineBuilderForm #5415

divyanshiGupta commented May 12, 2020 •

edited

openshift-ci-robot commented May 12, 2020

andrewballantyne left a comment

openshift-ci-robot commented May 13, 2020

andrewballantyne left a comment

andrewballantyne May 15, 2020

divyanshiGupta May 19, 2020

andrewballantyne May 19, 2020

divyanshiGupta May 19, 2020

andrewballantyne May 19, 2020

divyanshiGupta May 19, 2020

andrewballantyne May 19, 2020

divyanshiGupta May 19, 2020

divyanshiGupta May 19, 2020 •

edited

andrewballantyne May 19, 2020

andrewballantyne left a comment

openshift-ci-robot commented May 19, 2020

openshift-bot commented May 19, 2020

openshift-bot commented May 19, 2020

openshift-bot commented May 20, 2020

openshift-bot commented May 20, 2020

openshift-ci-robot commented May 20, 2020

Bug 1834945: Add sticky footer to PipelineBuilderForm #5415

Bug 1834945: Add sticky footer to PipelineBuilderForm #5415

Conversation

divyanshiGupta commented May 12, 2020 • edited

openshift-ci-robot commented May 12, 2020

andrewballantyne left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented May 13, 2020

andrewballantyne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

divyanshiGupta May 19, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewballantyne left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented May 19, 2020

openshift-bot commented May 19, 2020

openshift-bot commented May 19, 2020

openshift-bot commented May 20, 2020

openshift-bot commented May 20, 2020

openshift-ci-robot commented May 20, 2020

divyanshiGupta commented May 12, 2020 •

edited

divyanshiGupta May 19, 2020 •

edited