Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1838922: Show BC dropdown only for Noobaa Provisioners #5440

Merged
merged 1 commit into from May 22, 2020
Merged

Bug 1838922: Show BC dropdown only for Noobaa Provisioners #5440

merged 1 commit into from May 22, 2020

Conversation

bipuladh
Copy link
Contributor

Screenshot from 2020-05-14 16-12-05

@openshift-ci-robot openshift-ci-robot added the component/noobaa Related to noobaa-storage-plugin label May 14, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2020
@a2batic
Copy link
Contributor

a2batic commented May 15, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2020
@spadgett spadgett added this to the v4.5 milestone May 18, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 22, 2020
@bipuladh
Copy link
Contributor Author

/retest

@bipuladh bipuladh changed the title Show BC dropdown only for Noobaa Provisioners Bug 1838922: Show BC dropdown only for Noobaa Provisioners May 22, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 22, 2020
@openshift-ci-robot
Copy link
Contributor

@bipuladh: This pull request references Bugzilla bug 1838922, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1838922: Show BC dropdown only for Noobaa Provisioners

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

a2batic
a2batic reviewed May 22, 2020
View reviewed changes
Copy link
Contributor

@a2batic a2batic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Since we will always have only one Noobaa provisioner, we can keep it as constant.

frontend/packages/noobaa-storage-plugin/src/components/object-bucket-claim-page/create-obc.tsx
/>
</Firehose>
</div>
{state.scProvisioner.includes(NB_PROVISIONER) && !_.isEmpty(state.scProvisioner) && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{state.scProvisioner.includes(NB_PROVISIONER) && !_.isEmpty(state.scProvisioner) && (
{state.scProvisioner === NB_PROVISIONER && !_.isEmpty(state.scProvisioner) && (

frontend/packages/noobaa-storage-plugin/src/constants/index.ts
@@ -7,6 +7,7 @@ export const BY_EGRESS = 'Egress';
export const PROJECTS = 'Projects';
export const BUCKET_CLASS = 'Bucket Class';
export const OCS_NS = 'openshift-storage';
export const NB_PROVISIONER = 'noobaa.io/obc';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const NB_PROVISIONER = 'noobaa.io/obc';
export const NB_PROVISIONER = 'openshift-storage.noobaa.io/obc;

@bipuladh
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels May 22, 2020
@openshift-ci-robot
Copy link
Contributor

@bipuladh: This pull request references Bugzilla bug 1838922, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@a2batic
Copy link
Contributor

a2batic commented May 22, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a2batic, afreen23, bipuladh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e302198 into openshift:master May 22, 2020
@openshift-ci-robot
Copy link
Contributor

@bipuladh: All pull requests linked via external trackers have merged: openshift/console#5440. Bugzilla bug 1838922 has been moved to the MODIFIED state.

In response to this:

Bug 1838922: Show BC dropdown only for Noobaa Provisioners

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a2batic a2batic a2batic requested changes

@afreen23 afreen23 afreen23 approved these changes

@gnehapk gnehapk Awaiting requested review from gnehapk

Assignees

@a2batic a2batic

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/noobaa Related to noobaa-storage-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bipuladh @a2batic @openshift-ci-robot @afreen23 @spadgett @openshift-merge-robot