Bug 1826911: Add testcase that removes env vars #5447
Conversation
openshift-ci-robot
added
bugzilla/severity-medium
|
@zherman0: This pull request references Bugzilla bug 1826911, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
component/core
| expect(resourceText).toEqual(valueFrom); | ||
| expect(prefeixText).toEqual(prefix); | ||
| } else { | ||
| expect(resourceText).toEqual('hello-openshift'); |
There was a problem hiding this comment.
isPresent:false should equal hello-openshift seems a little strange to me.
There was a problem hiding this comment.
yeah, it is very strange, that is what the container name is in the first resource text box. The components have the same name. I should probably tweak that.
There was a problem hiding this comment.
So, I can rename things or add a data id, but I think for now I would prefer to leave it so I don't have to alter too much code, especially since this test is on the way out.
There was a problem hiding this comment.
Works for me till @dtaylor113 and our Cypress stuff is ready to roll.
/approve
/lgtm
|
/assign @benjaminapetersen |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, dtaylor113, zherman0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@zherman0: All pull requests linked via external trackers have merged: openshift/console#5447. Bugzilla bug 1826911 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Test case was failing because the environment was not cleaned between each test. Added new testcase that purposely removes environment variables between tests.