New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1834361: PVC table has overlapping text at some screen widths #5450
Bug 1834361: PVC table has overlapping text at some screen widths #5450
Conversation
@cyril-ui-developer: This pull request references Bugzilla bug 1834361, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d7605c8
to
2e7e46a
Compare
classNames('pf-m-hidden', 'pf-m-visible-on-lg'), // namespace | ||
'', // status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to always show namespace in case the user has "all projects" selected. I'd swap these styles.
classNames('pf-m-hidden', 'pf-m-visible-on-lg'), // namespace | |
'', // status | |
'', // namespace | |
classNames('pf-m-hidden', 'pf-m-visible-on-lg'), // status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spadgett Done! Thanks.
/cc @rhamilto |
2e7e46a
to
38f62bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cyril-ui-developer, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cyril-ui-developer: All pull requests linked via external trackers have merged: openshift/console#5450. Bugzilla bug 1834361 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @TheRealJon
/cc @benjaminapetersen @spadgett