Bug 1836028: fix traffic splitting required fields #5451
Conversation
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@nemesis09: This pull request references Bugzilla bug 1836028, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@nemesis09: This pull request references Bugzilla bug 1836028, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@nemesis09: This pull request references Bugzilla bug 1836028, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @invincibleJai |
|
@nemesis09 If i am not wrong, the issue is about not just adding the required field header but also to add yup validations :) I think the submit buttons should be disabled untill all the required fields are filled and we must show inline validation on the input change.
|
|
@karthikjeeyar Currently without yup validation for form's it shows error if required field are not provided i.e split/Revision is empty as in
So there two options
|
| <> | ||
| {header.name} | ||
| {header.required && ( | ||
| <span className="odc-multi-column-field__header--required-label">*</span> |
There was a problem hiding this comment.
| <span className="odc-multi-column-field__header--required-label">*</span> | |
| <span className="odc-multi-column-field__header--required-label" aria-hidden="true">*</span> |
nemesis09
force-pushed
the
fix-traffic-fields
branch
from
05d2815
to
3a9d107
Compare
|
/lgtm |
|
/test images |
|
/lgtm @nemesis09 Thanks , verified locally works as expected. check on point 2 above #5451 (comment) , we can even have it as separate issue if need be |
|
/assign @christianvogt |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, invincibleJai, jeff-phillips-18, nemesis09 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@nemesis09: All pull requests linked via external trackers have merged: openshift/console#5451. Bugzilla bug 1836028 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-3798
Analysis / Root cause:
In Traffic split modal split field has placeholder
100required fields are not marked with asterisk(*) in traffic modal
Solution Description:
add support for required label() in multicolumnfield headers
remove placeholder for traffic split
mark the required fields with asterisk()
Screens:
Code Coverage:
Browser Conformance: