Bug 1829341: Move cert input field after url input field in ovirt import wizard

[yaacov]

Move cert input field after url input field in ovirt import wizard

When importing from RHV the user needs to provide credentials (Username, Password, CA Certificate). The action to submit these fields is out of order. For users who are tabbing especially this is difficult because there is a field required to connect that is after the action to connect so they would be confused.

Screenshot:

[openshift-ci-robot]

@yaacov: This pull request references Bugzilla bug 1829341, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1829341: Move cert input field after url input field in ovirt import wizard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yaacov]

@suomiy @pcbailey @glekner @irosenzw please review

[openshift-ci-robot]

@yaacov: This pull request references Bugzilla bug 1829341, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1829341: Move cert input field after url input field in ovirt import wizard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[atiratree]

Looks good. You could also change the order of props in ovirt-initial-state for consistency

[yaacov]

could also change the order of props in ovirt-initial-state for consistency

sure ! done 👍

[atiratree]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suomiy, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/kubevirt-plugin/OWNERS [suomiy,yaacov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@yaacov: All pull requests linked via external trackers have merged: openshift/console#5471. Bugzilla bug 1829341 has been moved to the MODIFIED state.

In response to this:

Bug 1829341: Move cert input field after url input field in ovirt import wizard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.