Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1818722: Query Browser: Add text wrapping for table headers #5473

Merged

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented May 18, 2020

Also remove the type definition for sortable, which seems to no longer
be necessary.

FYI @sg00dwin, @spadgett

Before

before

After

after

Also remove the type definition for `sortable`, which seems to no longer
be necessary.
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 18, 2020
@openshift-ci-robot
Copy link
Contributor

@kyoto: This pull request references Bugzilla bug 1760758, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.3.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1760758: Query Browser: Add text wrapping for table headers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label May 18, 2020
@openshift-ci-robot openshift-ci-robot added component/monitoring Related to monitoring approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 18, 2020
@kyoto kyoto changed the title Bug 1760758: Query Browser: Add text wrapping for table headers Bug 1818722: Query Browser: Add text wrapping for table headers May 18, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 18, 2020
@openshift-ci-robot
Copy link
Contributor

@kyoto: This pull request references Bugzilla bug 1818722, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1818722: Query Browser: Add text wrapping for table headers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@kyoto: This pull request references Bugzilla bug 1818722, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1818722: Query Browser: Add text wrapping for table headers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@spadgett spadgett added this to the v4.5 milestone May 18, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 08d71a0 into openshift:master May 18, 2020
@openshift-ci-robot
Copy link
Contributor

@kyoto: All pull requests linked via external trackers have merged: openshift/console#5473. Bugzilla bug 1818722 has been moved to the MODIFIED state.

In response to this:

Bug 1818722: Query Browser: Add text wrapping for table headers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyoto kyoto deleted the query-browser-wrap-table-headers branch May 19, 2020 00:05
@kyoto
Copy link
Member Author

kyoto commented May 20, 2020

/cherrypick release-4.4

@openshift-cherrypick-robot

@kyoto: new pull request created: #5498

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants