New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1836801: Filter Disk Import activity that does not have progress yet #5476
Bug 1836801: Filter Disk Import activity that does not have progress yet #5476
Conversation
@rawagner: This pull request references Bugzilla bug 1836801, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -377,7 +377,8 @@ const plugin: Plugin<ConsumedExtensions> = [ | |||
}, | |||
isActivity: (resource) => | |||
resource?.status?.phase === 'ImportInProgress' && | |||
!!resource?.metadata?.ownerReferences?.[0], | |||
!!resource?.metadata?.ownerReferences?.[0] && | |||
!Number.isNaN(parseInt(resource?.status?.progress, 10)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, N/A progress might be a valid option for sources where CDI doesn't have progress implemented.
The best solution would be to check importer pod status (if it crashloops) - which is quite a heavy operation though.
Can't we just believe the status of a CRD (treat it as API) and show 0 or N/A
progress instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
{vmLink} | ||
</> | ||
) : ( | ||
<ActivityProgress title={VM_IMPORT_TITLE} progress={progress}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we include a key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ? Adding key is handled by ActivityBody https://github.com/openshift/console/blob/master/frontend/packages/console-shared/src/components/dashboard/activity-card/ActivityBody.tsx#L160
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, sorry - no need to have it here
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rawagner, suomiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rawagner: All pull requests linked via external trackers have merged: openshift/console#5476. Bugzilla bug 1836801 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.