Bug 1826481: Fix confusing subscription status for manual approve

[TheRealJon]

When a subscription shows an upgrade avaiable, but has a manual update approval strategy, installed operators, operator details > Subsctription, and Search > Subscription pages now provide a link to the install plan details page instead of showing 'Upgrading' status.

[openshift-ci-robot]

@TheRealJon: This pull request references Bugzilla bug 1826481, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1826481: Fix confusing subscription status for manual approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@TheRealJon: This pull request references Bugzilla bug 1826481, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1826481: Fix confusing subscription status for manual approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[itsptk]

FYI @tlwu2013

[TheRealJon]

/retest

[TheRealJon]

/retest

[TheRealJon]

/retest

[itsptk]

@TheRealJon Just to confirm, the new status will only appear when the approval strategy is manual? I just installed an operator with automatic approval and saw the UpgradePending status go by in the list view and was hoping that wouldn't change too.

[TheRealJon]

@itsptk Correct, the 'Upgrade available' link will only appear if the subscription is in an UpgradePending state and has a true 'RequiresApproval' condition, which means that the install plan has a manual approval strategy.

[TheRealJon]

/assign @benjaminapetersen

[TheRealJon]

/retest

[spadgett]

/approve
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[spadgett]

/bugzilla refresh

[openshift-ci-robot]

@spadgett: This pull request references Bugzilla bug 1826481, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@TheRealJon: All pull requests linked via external trackers have merged: openshift/console#5486. Bugzilla bug 1826481 has been moved to the MODIFIED state.

In response to this:

Bug 1826481: Fix confusing subscription status for manual approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.