Bug 1835938: Operands related views are disappeared due to missing Operand's `displayName` field in the CSV #5491

cyril-ui-developer · 2020-05-19T14:44:04Z

/assign @TheRealJon
/cc @benjaminapetersen @spadgett

openshift-ci-robot · 2020-05-19T14:44:12Z

@cyril-ui-developer: This pull request references Bugzilla bug 1835938, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1835938: Operands related views are disappeared due to missing Operand's displayName field in the CSV

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

frontend/packages/operator-lifecycle-manager/src/components/operand/index.tsx

spadgett · 2020-05-19T16:35:47Z

frontend/packages/operator-lifecycle-manager/src/components/clusterserviceversion.tsx

+          ? _.take(providedAPIs, 4).map((desc) => (
+              <div key={referenceForProvidedAPI(desc)}>
+                <Link to={`${route}/${referenceForProvidedAPI(desc)}`} title={desc.name}>
+                  {desc.displayName || _.startCase(desc.kind)}


_.startCase can do some weird things to some names (e.g. OAuthClient -> O Auth Client). I'd avoid it and just show the kind as-is.

Suggested change

{desc.displayName || _.startCase(desc.kind)}

{desc.displayName || desc.kind}

spadgett · 2020-05-19T16:35:57Z

frontend/packages/operator-lifecycle-manager/src/components/clusterserviceversion.tsx

@@ -702,7 +700,7 @@ export const CRDCard: React.SFC<CRDCardProps> = (props) => {
          kind={referenceForProvidedAPI(crd)}
          title={crd.name}
          linkTo={false}
-          displayName={crd.displayName}
+          displayName={crd.displayName || _.startCase(crd.kind)}


Suggested change

displayName={crd.displayName || _.startCase(crd.kind)}

displayName={crd.displayName || crd.kind}

spadgett · 2020-05-19T16:36:15Z

frontend/packages/operator-lifecycle-manager/src/components/operand/index.tsx

@@ -499,7 +499,7 @@ export const OperandDetails = connectToModel((props: OperandDetailsProps) => {

  const header = (
    <h2 className="co-section-heading">{`${
-      thisDefinition ? thisDefinition.displayName : kind
+      thisDefinition?.displayName ? thisDefinition.displayName : _.startCase(kind)


Suggested change

thisDefinition?.displayName ? thisDefinition.displayName : _.startCase(kind)

thisDefinition?.displayName || kind

spadgett · 2020-05-19T18:13:56Z

frontend/packages/operator-lifecycle-manager/src/components/operand/index.tsx

-    <h2 className="co-section-heading">{`${
-      thisDefinition ? thisDefinition.displayName : kind
-    } Overview`}</h2>
+    <h2 className="co-section-heading">{`${thisDefinition.displayName || kind} Overview`}</h2>


Suggested change

<h2 className="co-section-heading">{`${thisDefinition.displayName || kind} Overview`}</h2>

<h2 className="co-section-heading">{`${thisDefinition?.displayName || kind} Overview`}</h2>

spadgett · 2020-05-19T18:39:28Z

frontend/packages/operator-lifecycle-manager/src/components/operand/index.tsx

-    <h2 className="co-section-heading">{`${
-      thisDefinition ? thisDefinition.displayName : kind
-    } Overview`}</h2>
+    <h2 className="co-section-heading">{`${thisDefinition?.displayName || kind} Overview`}</h2>


Sorry, I missed this before, but this can be

Suggested change

<h2 className="co-section-heading">{`${thisDefinition?.displayName || kind} Overview`}</h2>

<h2 className="co-section-heading">{thisDefinition?.displayName || kind} Overview</h2>

TheRealJon

/lgtm

cyril-ui-developer · 2020-05-21T13:05:16Z

/retest

cyril-ui-developer · 2020-05-21T21:11:21Z

/retest

benjaminapetersen · 2020-05-27T14:11:52Z

/approve

benjaminapetersen · 2020-05-27T14:12:52Z

/hold

one request outstanding

spadgett

/approve
/lgtm
/hold cancel

openshift-ci-robot · 2020-05-27T16:55:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, cyril-ui-developer, spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/operator-lifecycle-manager/OWNERS~~ [benjaminapetersen,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-05-27T17:05:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-27T17:17:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-05-27T22:12:21Z

@cyril-ui-developer: All pull requests linked via external trackers have merged: openshift/console#5491. Bugzilla bug 1835938 has been moved to the MODIFIED state.

In response to this:

Bug 1835938: Operands related views are disappeared due to missing Operand's displayName field in the CSV

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot assigned TheRealJon May 19, 2020

openshift-ci-robot requested review from benjaminapetersen and spadgett May 19, 2020 14:44

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label May 19, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/olm Related to OLM labels May 19, 2020

TheRealJon reviewed May 19, 2020

View reviewed changes

frontend/packages/operator-lifecycle-manager/src/components/operand/index.tsx Outdated Show resolved Hide resolved

spadgett reviewed May 19, 2020

View reviewed changes

cyril-ui-developer force-pushed the operands-related--views-disappeared--missing-operand branch from b196625 to f19f570 Compare May 19, 2020 17:56

spadgett reviewed May 19, 2020

View reviewed changes

cyril-ui-developer force-pushed the operands-related--views-disappeared--missing-operand branch from f19f570 to 1bdd0e5 Compare May 19, 2020 18:24

spadgett reviewed May 19, 2020

View reviewed changes

TheRealJon self-requested a review May 20, 2020 16:09

TheRealJon approved these changes May 20, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2020

Operands related views missing displayName field

34edf44

cyril-ui-developer force-pushed the operands-related--views-disappeared--missing-operand branch from 1bdd0e5 to 34edf44 Compare May 27, 2020 14:43

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 27, 2020

spadgett approved these changes May 27, 2020

View reviewed changes

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2020

openshift-ci-robot assigned spadgett May 27, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020

openshift-merge-robot merged commit bbf5a18 into openshift:master May 27, 2020

spadgett added this to the v4.5 milestone May 28, 2020

cyril-ui-developer mentioned this pull request Jun 4, 2020

[release-4.5.z] Bug 1842968: - Operand's tab for Operand list view is missing #5653

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1835938: Operands related views are disappeared due to missing Operand's `displayName` field in the CSV #5491

Bug 1835938: Operands related views are disappeared due to missing Operand's `displayName` field in the CSV #5491

cyril-ui-developer commented May 19, 2020

openshift-ci-robot commented May 19, 2020

spadgett May 19, 2020

spadgett May 19, 2020

spadgett May 19, 2020

spadgett May 19, 2020

spadgett May 19, 2020

TheRealJon left a comment

cyril-ui-developer commented May 21, 2020 •

edited

cyril-ui-developer commented May 21, 2020

benjaminapetersen commented May 27, 2020

benjaminapetersen commented May 27, 2020

spadgett left a comment

openshift-ci-robot commented May 27, 2020

openshift-bot commented May 27, 2020

openshift-bot commented May 27, 2020

openshift-ci-robot commented May 27, 2020

	{desc.displayName \|\| _.startCase(desc.kind)}
	{desc.displayName \|\| desc.kind}

	displayName={crd.displayName \|\| _.startCase(crd.kind)}
	displayName={crd.displayName \|\| crd.kind}

	thisDefinition?.displayName ? thisDefinition.displayName : _.startCase(kind)
	thisDefinition?.displayName \|\| kind

	<h2 className="co-section-heading">{`${thisDefinition.displayName \|\| kind} Overview`}</h2>
	<h2 className="co-section-heading">{`${thisDefinition?.displayName \|\| kind} Overview`}</h2>

	<h2 className="co-section-heading">{`${thisDefinition?.displayName \|\| kind} Overview`}</h2>
	<h2 className="co-section-heading">{thisDefinition?.displayName \|\| kind} Overview</h2>

Bug 1835938: Operands related views are disappeared due to missing Operand's displayName field in the CSV #5491

Bug 1835938: Operands related views are disappeared due to missing Operand's displayName field in the CSV #5491

Conversation

cyril-ui-developer commented May 19, 2020

openshift-ci-robot commented May 19, 2020

spadgett May 19, 2020

Choose a reason for hiding this comment

spadgett May 19, 2020

Choose a reason for hiding this comment

spadgett May 19, 2020

Choose a reason for hiding this comment

spadgett May 19, 2020

Choose a reason for hiding this comment

spadgett May 19, 2020

Choose a reason for hiding this comment

TheRealJon left a comment

Choose a reason for hiding this comment

cyril-ui-developer commented May 21, 2020 • edited

cyril-ui-developer commented May 21, 2020

benjaminapetersen commented May 27, 2020

benjaminapetersen commented May 27, 2020

spadgett left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented May 27, 2020

openshift-bot commented May 27, 2020

openshift-bot commented May 27, 2020

openshift-ci-robot commented May 27, 2020

Bug 1835938: Operands related views are disappeared due to missing Operand's `displayName` field in the CSV #5491

Bug 1835938: Operands related views are disappeared due to missing Operand's `displayName` field in the CSV #5491

cyril-ui-developer commented May 21, 2020 •

edited