New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1837934: Fix Backing Store creation request #5499
Bug 1837934: Fix Backing Store creation request #5499
Conversation
/assign @afreen23 @a2batic @cloudbehl |
787c572
to
bc50bee
Compare
bc50bee
to
0f70bc0
Compare
@bipuladh: This pull request references Bugzilla bug 1837934, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Payload did not contain the field resources.request.storage.
0f70bc0
to
6bc42b3
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afreen23, bipuladh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -198,6 +198,12 @@ const PVCType: React.FC<PVCTypeProps> = ({ state, dispatch }) => { | |||
TiB: 'TiB', | |||
}; | |||
|
|||
// Noobaa expected Ti console standrad is to show TiB | |||
const unitConverter = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't we use some generic converter present in OCP shared or public code? I don't think this is the first time implementation.
@bipuladh: All pull requests linked via external trackers have merged: openshift/console#5499. Bugzilla bug 1837934 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.4 |
@bipuladh: new pull request created: #5511 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The screenshot shows the request going through as expected:
Payload updated to contain the field resources.request.storage.