New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1838472: Disable add button for unfilled healthchecks form #5516
Bug 1838472: Disable add button for unfilled healthchecks form #5516
Conversation
@rottencandy: This pull request references Bugzilla bug 1838472, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @vikram-raj |
@@ -50,6 +49,10 @@ const AddHealthChecks: React.FC<FormikProps<FormikValues> & AddHealthChecksProps | |||
} = resource; | |||
const kindForCRDResource = referenceFor(resource); | |||
const resourceKind = modelFor(kindForCRDResource).crd ? kindForCRDResource : kind; | |||
const { | |||
values: { healthChecks }, | |||
} = useFormikContext<FormikValues>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to get the value from using the hook as values
is already present in this component just destructure the values from the props and use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
@@ -117,7 +120,7 @@ const AddHealthChecks: React.FC<FormikProps<FormikValues> & AddHealthChecksProps | |||
errorMessage={status && status?.errors?.json?.message} | |||
isSubmitting={isSubmitting} | |||
submitLabel={healthCheckAdded ? 'Save' : 'Add'} | |||
disableSubmit={!dirty || !_.isEmpty(errors)} | |||
disableSubmit={isFormClean || !_.isEmpty(errors)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to remove the check for dirty
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The form modifies the dirty
prop even if the probe section is simply opened, without modifying any of the fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest keeping the dirty check as well.
dirty
returns true
if values are not deeply equal from initial values, false
otherwise
disableSubmit={isFormClean || !_.isEmpty(errors)} | |
disableSubmit={isFormClean || !dirty || !_.isEmpty(errors)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
This reverts commit e2f8093. useFormikContext() is not used anymore, so no need to mock it.
/assign @rohitkrai03 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rohitkrai03, rottencandy, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rottencandy: All pull requests linked via external trackers have merged: openshift/console#5516. Bugzilla bug 1838472 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-3815
Analysis / Root cause:
Add button from Health checks page gets activated and clickable even though we don't add anything.
Solution Description:
Only enable "Add" button if any of the health probes prop
enabled
istrue
.Screen shots / Gifs for design review:
Browser conformance: