Bug 1839075: updates helptext for eventSources #5538
Conversation
openshift-ci-robot
added
bugzilla/severity-low
|
@invincibleJai: This pull request references Bugzilla bug 1839075, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
@invincibleJai: This pull request references Bugzilla bug 1839075, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
invincibleJai
force-pushed
the
fix-evsrc-helptext
branch
from
cb43921
to
ae67b13
Compare
|
@sahil143 updated and updated helpText for Service Account to cc @beaumorley |
|
Text look grammatically correct and consistent. Note -> I used documentation to make the recommendations. If any of them look technically off, LMK and I can take another stab. Otherwise OK with me. |
| <InputField type={TextInputTypes.text} name="data.pingsource.data" label="Data" /> | ||
| <InputField | ||
| type={TextInputTypes.text} | ||
| name="data.pingsource.data" |
There was a problem hiding this comment.
while the v1alpha1 uses data, see: https://github.com/knative/eventing/blob/master/pkg/apis/sources/v1alpha1/ping_types.go#L77
the v1alpah2 will use jsonData, see: https://github.com/knative/eventing/blob/master/pkg/apis/sources/v1alpha2/ping_types.go#L68
There was a problem hiding this comment.
@matzew Thanks , Currently based on CRD response v1alpha1 is picked as has both served and storage true so having data. Once it's v1alpha2 we need to update jsonData .
Do you see that served and storage to be true with 1.7.1 of serverless for 4.5 ??
|
@matzew let me know if helptext in description images looks good or they needs to be updated/modified |
|
lgtm
On Tue 26. May 2020 at 09:09, Jaivardhan Kumar ***@***.***> wrote:
@matzew <https://github.com/matzew> let me know if helptext in
description images looks good or they needs to be updated/modified
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5538 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGPTVAKQ5GBLPJTVU3TNLRTNTKXANCNFSM4NHYFQYA>
.
--
Sent from Gmail Mobile
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@invincibleJai: All pull requests linked via external trackers have merged: openshift/console#5538. Bugzilla bug 1839075 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-3414
Analysis / Root cause:
HelpText were missing for some of the sources
Solution Description:
Updated helpText for sources
Screen shots / Gifs for design review:
cc @openshift/team-devconsole-ux @beaumorley
Browser conformance: