Bug 1837677: open the VNC console in a new window

[glekner]

This enables opening the vnc console in a new window.

If the main window context is changed (e.g. move from console to details tab) then the new window will close aswell.

Screens:

---

[openshift-ci-robot]

@glekner: This pull request references Bugzilla bug 1837677, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1837677: open the VNC console in a new window

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[glekner]

@rawagner can you review :)

[yaacov]

@glekner Wow Great !

cc:// @jelkosz

[yaacov]

@glekner great 🍰 I liked better the option of the new window with no buttons at all ( just the terminal ) can you make a screenshot of that option too ?

[yfrimanm]

This is great @glekner !

Please take a look at this design suggestion I have for rearranging the buttons
https://imgur.com/QDr2nMT
WDYT?

Thanks.

[glekner]

• Applied @yfrimanm suggestion
• If Window creation fails, an alert is shown @yaacov

[yaacov]

can you add the vmi name + "Console" as the window name ?

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: glekner, yaacov
To complete the pull request process, please assign jhadvig
You can assign the PR to them by writing /assign @jhadvig in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[atiratree]

Looks pretty good, but it has few limitations which could be fixed.

If the main window context is changed (e.g. move from console to details tab) then the new window will close aswell.

IMO this is very counter-intuitive and we would get complaints about this soon.

cons

• you need to have a host window and not use it in the future. Not until you close the terminal
• you can't reference the terminal URL in case you need a quick look at the VM (more clicks have to be done)

We should have referenceable URL and proper standalone window for this to be user friendly.

Luckily something similar has already been done and is used in the console (che workspaces terminal):

they also have an option to open the terminal in standalone window at my.domain/terminal

this is how the init step looks (see the PR for other examples):

can we get inspired by this and do something similar? And have our own url with the vm name like: /k8s/ns/default/virtualmachines/my-example-vm/standalone-console ?

[yaacov]

Notes:

can we get inspired by this and do something similar? And have our own url with the vm name like: /k8s/ns/default/virtualmachines/my-example-vm/standalone-console ?

This is kubevirt backend endpoint for vnc [1]
/apis/subresources.kubevirt.io/v1alpha3/namespaces/NAMESPACE/virtualmachineinstances/VM/vnc
[1] https://kubevirt.io/2019/Access-Virtual-Machines-graphic-console-using-noVNC.html

[atiratree]

This is kubevirt backend endpoint for vnc [1]
/apis/subresources.kubevirt.io/v1alpha3/namespaces/NAMESPACE/virtualmachineinstances/VM/vnc

yes we are using that internally - although our console is also for serial and rdp.

Do you want to encode the selected console into the url? Like /default/virtualmachines/my-vm/consoles?console=vnc

also, not sure we should be changing vm -> vmi endpoint, because the consoles page should be also accessible when the vmi is non existent

[glekner]

Do you want to encode the selected console into the url? Like /default/virtualmachines/my-vm/consoles?console=vnc

sounds like a good idea. do we need to handle permissions to those namespaces or they will already be dealt with?

[atiratree]

sounds like a good idea. do we need to handle permissions to those namespaces or they will already be dealt with?

+1, we could have the same approach like the details page with StatusBox and show the appropriate error or Restricted Access message. Although we should offer redirect back to the console in that case.

[glekner]

Closing in favour of #5593