Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1839883: Pipeline Builder supports invalid task refs #5553

Merged
merged 1 commit into from May 28, 2020
Merged

Bug 1839883: Pipeline Builder supports invalid task refs #5553

merged 1 commit into from May 28, 2020

Conversation

andrewballantyne
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/ODC-3578

Analysis / Root cause:
When uploading a Pipeline that references tasks that do not exist, the app would white-screen if you try to click on that bubble in the Pipeline Builder.

Solution Description:
Check on creation of the nodes if they reference a valid task. If they do not, swap the node for an invalid list item forcing a re-selection.

Screen shots / Gifs for design review:
@openshift/team-devconsole-ux

Kapture 2020-05-25 at 16 06 33

Unit test coverage report:

See #4805 for upgrades to the tests.

Test setup:

  • Pipeline Operator
  • A Pipeline that references a task that does not exist (use a Pipeline and just change the taskRef name to something that doesn't exist)

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label May 25, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2020
@andrewballantyne andrewballantyne changed the title Pipeline Builder supports invalid task refs Bug 1839883: Pipeline Builder supports invalid task refs May 25, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label May 25, 2020
@openshift-ci-robot
Copy link
Contributor

@andrewballantyne: This pull request references Bugzilla bug 1839883, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1839883: Pipeline Builder supports invalid task refs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 25, 2020
jerolimov
jerolimov suggested changes May 27, 2020
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally and works fine 👍
I have two small TypeScript ideas, everything else lgtm. Get my flag already.
/lgtm

...tend/packages/dev-console/src/components/pipelines/pipeline-topology/InvalidTaskListNode.tsx Outdated Show resolved Hide resolved
frontend/packages/dev-console/src/components/pipelines/pipeline-topology/TaskListNode.tsx Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@jerolimov
Copy link
Member

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
jerolimov
jerolimov approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8a15950 into openshift:master May 28, 2020
@openshift-ci-robot
Copy link
Contributor

@andrewballantyne: All pull requests linked via external trackers have merged: openshift/console#5553. Bugzilla bug 1839883 has been moved to the MODIFIED state.

In response to this:

Bug 1839883: Pipeline Builder supports invalid task refs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrewballantyne
Copy link
Contributor Author

/cherry-pick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 28, 2020
Merged
@openshift-cherrypick-robot
Copy link

@andrewballantyne: new pull request created: #5612

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerolimov jerolimov jerolimov approved these changes

@abhinandan13jan abhinandan13jan Awaiting requested review from abhinandan13jan

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@jerolimov jerolimov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@andrewballantyne @openshift-ci-robot @jerolimov @openshift-cherrypick-robot @spadgett @openshift-merge-robot