Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1834163: Don't show error on unedited form #5558

Merged
merged 1 commit into from May 26, 2020
Merged

Bug 1834163: Don't show error on unedited form #5558

merged 1 commit into from May 26, 2020

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented May 26, 2020

On the Affinity form, when we add an affinity we show a form with an error message before users start to edit the form,

This PR adds a check that form is changed before showing the error message.

@openshift-ci-robot
Copy link
Contributor

@yaacov: This pull request references Bugzilla bug 1834163, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1834163: Don't show error on unedited form

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin labels May 26, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2020
@yaacov
Copy link
Member Author

yaacov commented May 26, 2020

@suomiy @pcbailey @irosenzw @glekner please review

glekner
glekner suggested changes May 26, 2020
View reviewed changes
...omponents/modals/scheduling-modals/affinity-modal/components/affinity-edit/affinity-edit.tsx Outdated
onExpressionDelete,
] = useIDEntities<AffinityLabel>(affinity?.expressions);

const onExpressionChange = (updatedEntity: AffinityLabel) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this behaviour should also be implemented on the node fields.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+ this could be implemented inside useIDEntities hook

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using useMemo 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now in useIDEntities 🍰

@yaacov yaacov force-pushed the dont-show-error-on-unedited-form branch 7 times, most recently from 4323a2e to b890499 Compare May 26, 2020 11:18
atiratree
atiratree reviewed May 26, 2020
View reviewed changes
...omponents/modals/scheduling-modals/affinity-modal/components/affinity-edit/affinity-edit.tsx Outdated
@@ -44,14 +44,22 @@ export const AffinityEdit: React.FC<AffinityEditProps> = ({
onExpressionAdd,
onExpressionChange,
onExpressionDelete,
affinityExpressionChanged,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
affinityExpressionChanged,
initialAffinityExpressionChanged,

...omponents/modals/scheduling-modals/affinity-modal/components/affinity-edit/affinity-edit.tsx Outdated
onFieldAdd,
onFieldChange,
onFieldDelete,
affinityFieldChanged,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
affinityFieldChanged,
initialAffinityFieldChanged,

...omponents/modals/scheduling-modals/affinity-modal/components/affinity-edit/affinity-edit.tsx Outdated
affinityFieldChanged,
] = useIDEntities<AffinityLabel>(affinity?.fields);

const affinityChanged = affinityFieldChanged || affinityExpressionChanged;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@yaacov yaacov force-pushed the dont-show-error-on-unedited-form branch from b890499 to 0eb793b Compare May 26, 2020 11:38
@atiratree
Copy link
Member

/approve

ping @glekner

@glekner
Copy link
Contributor

glekner commented May 26, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, suomiy, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0d6502d into openshift:master May 26, 2020
@openshift-ci-robot
Copy link
Contributor

@yaacov: All pull requests linked via external trackers have merged: openshift/console#5466, openshift/console#5558. Bugzilla bug 1834163 has been moved to the MODIFIED state.

In response to this:

Bug 1834163: Don't show error on unedited form

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atiratree atiratree atiratree left review comments

@glekner glekner glekner requested changes

@mareklibra mareklibra Awaiting requested review from mareklibra

Assignees

@glekner glekner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yaacov @openshift-ci-robot @atiratree @glekner @spadgett @openshift-merge-robot