Bug 1840256: Fix for re-display of EventSources with links in topology #5569
Conversation
openshift-ci-robot
added
kind/bug
|
@jeff-phillips-18: This pull request references Bugzilla bug 1840256, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
| @@ -17,6 +17,10 @@ export default class SVGAnchor extends AbstractAnchor { | |||
| } | |||
|
|
|||
| getCircleLocation(circle: SVGCircleElement, reference: Point): Point { | |||
| if (!circle.viewportElement) { | |||
There was a problem hiding this comment.
Can't you do this once in getLocation?
There was a problem hiding this comment.
Though they are not part of the Anchor interface, it is possible that someone use those functions directly and then the problem would still exist.
There was a problem hiding this comment.
Those functions should be private.
There was a problem hiding this comment.
Moved the check to getLocation made the get<xxx>Location functions private.
jeff-phillips-18
force-pushed
the
invalid-edges
branch
from
a9e0925
to
fa8f3f1
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@jeff-phillips-18: All pull requests linked via external trackers have merged: openshift/console#5569. Bugzilla bug 1840256 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-3942
Analysis / Root cause:
Re-calculating the endpoint for the event source link edge is done before the event source has been redrawn and the svg element is not yet ready to compute the location.
Solution Description:
Check for a valid svg element prior to computing the anchor location.
/kind bug