Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1809023: Minor fixes in the OCS Installation and Independent Dashboard #5580

Merged
merged 1 commit into from May 28, 2020
Merged

Bug 1809023: Minor fixes in the OCS Installation and Independent Dashboard #5580

merged 1 commit into from May 28, 2020

Conversation

bipuladh
Copy link
Contributor

  • Fix flickering details card in the Independent Mode Dashboard
  • Fix filtered "Select All" deselection in OCS Install Page.

@openshift-ci-robot openshift-ci-robot added component/ceph Related to ceph-storage-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 27, 2020
@bipuladh bipuladh force-pushed the fix_minor_ocs branch 2 times, most recently from 23e8123 to 430fcef Compare May 27, 2020 08:09
bipuladh
bipuladh commented May 27, 2020
View reviewed changes
frontend/packages/ceph-storage-plugin/src/components/ocs-install/install-page.tsx Outdated
Comment on lines 54 to 57
getAnnotations(clusterServiceVersionObj)?.[
'external.features.ocs.openshift.io/script'
],
),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed in red-hat-storage/ocs-operator#530

cloudbehl
cloudbehl reviewed May 27, 2020
View reviewed changes
Copy link
Contributor

@cloudbehl cloudbehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you accommodate the changes mentioned below:

The text & box needs to be grayed out once values are filled.

The name of the file should be different from exporter.py for the script.
Then name we planned is:
ceph-external-cluster-details-exporter.py

The download script needs to have a hand cursor. Also I think there should be a download icon next to it.

The browse button also needs to have a hand cursor.

@cloudbehl
Copy link
Contributor

The selection & deselection is still not working as expected while testing the PR.

How I tested:

  1. select all the nodes
  2. select the filter
  3. deselect the filtered node

You will see all the nodes getting deselected.

@bipuladh
Copy link
Contributor Author

The selection & deselection is still not working as expected while testing the PR.

How I tested:

  1. select all the nodes
  2. select the filter
  3. deselect the filtered node

You will see all the nodes getting deselected.

I cannot reproduce this.

@bipuladh
Copy link
Contributor Author

captured (6)
Filters working as expected.

@bipuladh bipuladh requested a review from cloudbehl May 27, 2020 11:22
@bipuladh bipuladh changed the title Minor fixes in the OCS Installation and Independent Dashboard Bug 1834186: Minor fixes in the OCS Installation and Independent Dashboard May 27, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 27, 2020
@openshift-ci-robot
Copy link
Contributor

@bipuladh: This pull request references Bugzilla bug 1834186, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "OCS 4.5.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1834186: Minor fixes in the OCS Installation and Independent Dashboard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bipuladh bipuladh changed the title Bug 1834186: Minor fixes in the OCS Installation and Independent Dashboard Bug 1809023: Minor fixes in the OCS Installation and Independent Dashboard May 27, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 27, 2020
@openshift-ci-robot
Copy link
Contributor

@bipuladh: This pull request references Bugzilla bug 1809023, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1809023: Minor fixes in the OCS Installation and Independent Dashboard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bipuladh bipuladh mentioned this pull request May 27, 2020
Merged
@cloudbehl
Copy link
Contributor

/lgtm

@cloudbehl
Copy link
Contributor

cloudbehl commented May 28, 2020 •
edited

/test images

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2020
@openshift-ci-robot
Copy link
Contributor

@cloudbehl: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test analyze
  • /test backend
  • /test e2e-gcp-console
  • /test frontend
  • /test images

Use /test all to run all jobs.

In response to this:

/test image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, cloudbehl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4b22c47 into openshift:master May 28, 2020
@openshift-ci-robot
Copy link
Contributor

@bipuladh: All pull requests linked via external trackers have merged: openshift/console#5580, openshift/console#4582. Bugzilla bug 1809023 has been moved to the MODIFIED state.

In response to this:

Bug 1809023: Minor fixes in the OCS Installation and Independent Dashboard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afreen23 afreen23 Awaiting requested review from afreen23

@shyRozen shyRozen Awaiting requested review from shyRozen

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

Assignees

@cloudbehl cloudbehl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bipuladh @cloudbehl @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot