Bug 1840567: Fix helm action menu in topology sidebar

[rohitkrai03]

Fixes - https://issues.redhat.com/browse/ODC-3949

This PR -

• Fixes the issue where helm action menu is cut off from bottom when there are no release notes in a helm release.
• Adds empty state for helm releases without any release notes,

Screenshots -
cc: @openshift/team-devconsole-ux

Before -

After -

[openshift-ci-robot]

@rohitkrai03: This pull request references Bugzilla bug 1840567, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1840567: Fix helm action menu in topology sidebar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rohitkrai03]

/bugzilla refresh

[openshift-ci-robot]

@rohitkrai03: An error was encountered adding this pull request to the external tracker bugs for bug 1840567 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 32000: There was an error reported for a GitHub REST call. URL: https://api.github.com/repos/openshift/console/pulls/5589 Error: 403 Forbidden at /loader/0x564436ca2a80/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. at /loader/0x564436ca2a80/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. eval {...} called at /loader/0x564436ca2a80/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 98 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x564442...', 'https://api.github.com/repos/openshift/console/pulls/5589', 'GET') called at /loader/0x564436ca2a80/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x564442...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x5644432e60d0)') called at /loader/0x564436ca2a80/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x564436ca2a80/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x5644432e60d0)', 1) called at /loader/0x564436ca2a80/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x5644431b8840)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 877 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x56444331fb00)', 'HASH(0x564442fda928)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x564442fda928)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1170 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x564442c4aa80)') called at /loader/0x564436ca2a80/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5644432c02f0)') called at (eval 2446) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x564443767d38)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 295 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x564443767d38)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x5644437fc300)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x564443073508)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x564443073508)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x5644437fc300)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x5644437fc300)') called at (eval 2446) line 0 eval {...} called at (eval 2446) line 0
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rohitkrai03]

/bugzilla refresh

[rohitkrai03]

/bugzilla refresh

[openshift-ci-robot]

@rohitkrai03: This pull request references Bugzilla bug 1840567, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[divyanshiGupta]

Code looks good to me. Will add lgtm once UX approves the PR.

[invincibleJai]

@divyanshiGupta i don't see this change impacts UXD is a way that we need approval ? shall we add lgtm

@rohitkrai03 WDYT?

[divyanshiGupta]

@invincibleJai @rohitkrai03 tagged UX so I thought he wants to have UX look at this PR and add their approval. If not I can add lgtm.

[openshift-ci-robot]

@rohitkrai03: This pull request references Bugzilla bug 1840567, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1840567: Fix helm action menu in topology sidebar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rohitkrai03]

@invincibleJai Now the PR has some UX changes based on conversation on slack. It adds an empty state. So we need approval from UX. cc: @parvathyvr @serenamarie125

[parvathyvr]

Hi @rohitkrai03 1 small change.can you add a '.' to the end of the sentence "Release Notes are not available for this Helm Chart." Even in the Monitoring tab example Serena had posted,I notice that we end sentences with a '.'

[rohitkrai03]

@parvathyvr Updated. Sorry I missed that earlier.

[parvathyvr]

LGTM!

[divyanshiGupta]

/lgtm

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[divyanshiGupta]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyanshiGupta, invincibleJai, parvathyvr, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [invincibleJai,rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@rohitkrai03: All pull requests linked via external trackers have merged: openshift/console#5589. Bugzilla bug 1840567 has been moved to the MODIFIED state.

In response to this:

Bug 1840567: Fix helm action menu in topology sidebar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.