Bug 1840585: Add loading box when helm readme is being fetched

[rohitkrai03]

Fixes: https://issues.redhat.com/browse/ODC-3790

Analysis / Root cause: Sometimes it takes time to load readme content of helm charts in sidebar which gives user the impression that nothing is happening.

Solution Description: Adds a loading box in the sidebar while readme is being fetched for helm chart.

Screen shots / Gifs for design review:
cc: @openshift/team-devconsole-ux @parvathyvr @beaumorley

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@rohitkrai03: This pull request references Bugzilla bug 1840585, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1840585: Add loading box when helm readme is being fetched

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[divyanshiGupta]

Code looks good. Will add lgtm after UX approval.

[parvathyvr]

LGTM!

[divyanshiGupta]

/lgtm

[andrewballantyne]

This is a small (but I think nice) win... however you will need Christian's approval @rohitkrai03

/assign @christianvogt

[christianvogt]

I like the idea. I'm sure UX will have some suggestion on the text being used instead of Loading Markdown.

In your gif, the last item shows the loading indicator and then nothing shows up. I think this could be confusing. Although that's definitely an edge case because chances are if the chart had a README file present, it most likely will have content.

@beaumorley got any suggestion?
cc @openshift/team-devconsole-ux @serenamarie125

[openshift-ci-robot]

@rohitkrai03: This pull request references Bugzilla bug 1840585, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1840585: Add loading box when helm readme is being fetched

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[christianvogt]

Thanks @andrewballantyne for pointing out that @parvathyvr already gave a lgtm.

In that case:
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, divyanshiGupta, invincibleJai, jcaianirh, parvathyvr, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@rohitkrai03: All pull requests linked via external trackers have merged: openshift/console#5594. Bugzilla bug 1840585 has been moved to the MODIFIED state.

In response to this:

Bug 1840585: Add loading box when helm readme is being fetched

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.