New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1840720: Fix for updates of Helm charts in topology #5601
Bug 1840720: Fix for updates of Helm charts in topology #5601
Conversation
@jeff-phillips-18: This pull request references Bugzilla bug 1840720, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jeff-phillips-18: All pull requests linked via external trackers have merged: openshift/console#5601. Bugzilla bug 1840720 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-3477
Analysis / Root cause:
Topology removes resources from the retrieved list as they are being consumed by the different types (Helm, Knative, Operator Backed, etc). Since the view is updated when the helm releases are retrieved, the items were removed from the list and hence no longer transformed into viewable nodes.
Solution Description:
Copy the resource data into new mutable arrays so that the original resource lists are not changed during the transforms.
/kind bug