Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update owners files for dev-console and knative-plugin #5608

Merged
merged 1 commit into from Jun 1, 2020
Merged

update owners files for dev-console and knative-plugin #5608

merged 1 commit into from Jun 1, 2020

Conversation

christianvogt
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label May 27, 2020
@openshift-ci-robot openshift-ci-robot added component/knative Related to knative-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 27, 2020
@andrewballantyne
Copy link
Contributor

git-service?

@rohitkrai03
Copy link
Contributor

I just came to say the exact same thing. LOL.

@openshift-ci-robot openshift-ci-robot added the component/git-service Related to git-service label May 28, 2020
@christianvogt
Copy link
Contributor Author

@andrewballantyne @rohitkrai03 I've updated the git-service OWNERS file as well.

andrewballantyne
andrewballantyne approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 499e2fc into openshift:master Jun 1, 2020
@spadgett spadgett added this to the v4.5 milestone Jun 1, 2020
@spadgett spadgett modified the milestones: v4.5, v4.6 Jul 9, 2020
@christianvogt christianvogt deleted the update-owners branch August 20, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar

Assignees

@andrewballantyne andrewballantyne

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/git-service Related to git-service component/knative Related to knative-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@christianvogt @andrewballantyne @rohitkrai03 @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot