Bug 1840940: Fix notification drawer to display cluster version upgrade messaging

[jcaianirh]

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1840940

cc: @spadgett

[jcaianirh]

/bugzilla refresh

[openshift-ci-robot]

@jcaianirh: This pull request references Bugzilla bug 1840940, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dtaylor113]

LGTM, although shouldn't there be a link in the alert notification in the drawer? Something like 'Update Cluster'. (Should "Update Cluster" actually launch the modal or goto Cluster Settings?)
Currently, there is no visual indication that one can/should click on the alert to navigate to Cluster Settings to update the cluster.

[benjaminapetersen]

I tend to agree, I would expect a link in the notification as well. Just a confirmation question.

[spadgett]

/approve
/lgtm

Thanks @jcaianirh

[spadgett]

/lgtm cancel

I agree. We should have a link to the cluster settings page and match the message to the design.

We should update the notification message and add a link.

[jcaianirh]

@spadgett , @dtaylor113 , @benjaminapetersen I thought since there was only one link (ie no alert + alert action) we decided the actual alert would be sufficient. Checking in with @cshinn

EDIT: Checked with Chris, adding link.

[spadgett]

@spadgett , @dtaylor113 , @benjaminapetersen I thought since there was only one link (ie no alert + alert action) we decided the actual alert would be sufficient. Checkin in with @cshinn

OK, I missed that clicking the notification itself takes you there. The message matches the design https://openshift.github.io/openshift-origin-design/designs/administrator/4.4/notification-drawer/

/lgtm

[spadgett]

/hold

[jcaianirh]

Updated notification message with link to update cluster, and remove the masthead toolbar icon that appears when an update is available.

[dtaylor113]

Thanks @jcaianirh , LGTM

[jcaianirh]

/hold cancel

[spadgett]

/approve
/lgtm
/hold cancel

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, jcaianirh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jcaianirh: All pull requests linked via external trackers have merged: openshift/console#5611. Bugzilla bug 1840940 has been moved to the MODIFIED state.

In response to this:

Bug 1840940: Fix notification drawer to display cluster version upgrade messaging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.