Bug 1834671: Acknowledge strategies when computing if VM is running #5619
Conversation
atiratree
commented
May 28, 2020
atiratree
commented
- fix statuses
- fix visibility of VM action like Restart/Start/Stop
- disable details edit and nic/disks CRUD actions when VM is running
openshift-ci-robot
added
the
approved
- fix statuses - fix visibility of VM action like Restart/Start/Stop - disable details edit and nic/disks CRUD actions when VM is running
atiratree
changed the title
openshift-ci-robot
added
bugzilla/severity-high
|
@suomiy: This pull request references Bugzilla bug 1834671, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| // according to https://github.com/kubevirt/kubevirt/blob/master/pkg/virt-api/rest/subresource.go | ||
| const isFinalPhase = | ||
| !vmiPhase || [VMIPhase.Unknown, VMIPhase.Failed, VMIPhase.Succeeded].includes(vmiPhase); | ||
| const isVMError = (vm: VMKind): VMStatusBundle => { |
There was a problem hiding this comment.
Nitpick that doesn't need to be addressed now.
Typically, when I see a function that starts with 'is', I expect a boolean return type. I think we should eventually change these function names to better match what they're doing, such as getStoppingStatus. If we need boolean tests for them, it would be trivial to create functions that coerce the return values of these functions to a boolean. Just my two cents.
There was a problem hiding this comment.
Yes I agree. I think we should refactor the whole logic of this file to make more sense. And not be it one dimensional array of ifs. And test it as well.
Nevertheless, I think we should not do it here in this bug fix but a bit later.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pcbailey, suomiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@suomiy: All pull requests linked via external trackers have merged: openshift/console#5619, openshift/console#5405. Bugzilla bug 1834671 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
