Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1841302: Remove custom ClusterTriggerBinding details page #5623

Conversation

andrewballantyne
Copy link
Contributor

@andrewballantyne andrewballantyne commented May 28, 2020

Fixes:
https://issues.redhat.com/browse/ODC-4033

Analysis / Root cause:
Listing namespaced Event Listener resources on Cluster Trigger Binding pages does not work.

Solution Description:
Remove the custom Cluster Trigger Binding page, let it has the default k8s page.

Screen shots / Gifs for design review:

Before:
Screen Shot 2020-05-28 at 3 27 38 PM
Screen Shot 2020-05-28 at 3 27 52 PM

After:
Screen Shot 2020-05-28 at 3 26 24 PM

Unaffected namespaced Trigger Bindings:
Screen Shot 2020-05-28 at 3 26 14 PM

Test setup:

  • Pipeline Operator 1.0.x installed
  • Create a new project
  • oc apply -f https://raw.githubusercontent.com/andrewballantyne/pipeline-scratch-pad/master/examples/triggers/ui/resources.yaml
  • Add a Cluster Trigger Binding and a Trigger Binding trigger to the pipeline added to the project you're in
    • Go to the Pipelines page, "Add Trigger" on the pipeline from the actions
    • In the first drop down select github, other values do not matter - just fill them in with garbage
    • Repeat and do it again for github-push

Viewing the Cluster Trigger Binding (github-push) resource should show no links.
Viewing the namespaced Trigger Binding (github) resource should show the Event Listener link.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label May 28, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@andrewballantyne andrewballantyne changed the title Remove custom ClusterTriggerBinding details page Bug 1841302: Remove custom ClusterTriggerBinding details page May 28, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 28, 2020
@openshift-ci-robot
Copy link
Contributor

@andrewballantyne: This pull request references Bugzilla bug 1841302, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1841302: Remove custom ClusterTriggerBinding details page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit 48790cd into openshift:master May 28, 2020
@openshift-ci-robot
Copy link
Contributor

@andrewballantyne: All pull requests linked via external trackers have merged: openshift/console#5623. Bugzilla bug 1841302 has been moved to the MODIFIED state.

In response to this:

Bug 1841302: Remove custom ClusterTriggerBinding details page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants