Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1842351: Network definitions to nad #5634

Merged
merged 1 commit into from Jun 1, 2020
Merged

Bug 1842351: Network definitions to nad #5634

merged 1 commit into from Jun 1, 2020

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jun 1, 2020 •
edited

Typo fix:

After:
screenshot-localhost_9000-2020 06 01-13_57_09
screenshot-localhost_9000-2020 06 01-13_57_38

Before:
screenshot-localhost_9000-2020 06 01-13_55_39
screenshot-localhost_9000-2020 06 01-13_56_30

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 1, 2020
@openshift-ci-robot
Copy link
Contributor

@yaacov: This pull request references Bugzilla bug 1842351, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1842351: Network definitions to nad

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 1, 2020
@openshift-ci-robot
Copy link
Contributor

@yaacov: This pull request references Bugzilla bug 1842351, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1842351: Network definitions to nad

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yaacov
Copy link
Member Author

yaacov commented Jun 1, 2020

@suomiy @pcbailey @irosenzw @glekner please review

@yaacov yaacov force-pushed the network-definitions-to-nad branch from 5046e94 to ff2dc55 Compare June 1, 2020 11:25
@glekner
Copy link
Contributor

glekner commented Jun 1, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2020
@openshift-merge-robot openshift-merge-robot merged commit 0ce9619 into openshift:master Jun 1, 2020
@openshift-ci-robot
Copy link
Contributor

@yaacov: All pull requests linked via external trackers have merged: openshift/console#5634. Bugzilla bug 1842351 has been moved to the MODIFIED state.

In response to this:

Bug 1842351: Network definitions to nad

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone Jun 1, 2020
@openshift-ci-robot openshift-ci-robot mentioned this pull request Jun 2, 2020
Merged
@yaacov
Copy link
Member Author

yaacov commented Jun 2, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 2, 2020
Closed
@openshift-cherrypick-robot
Copy link

@yaacov: new pull request created: #5656

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett modified the milestones: v4.5, v4.6 Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mareklibra mareklibra Awaiting requested review from mareklibra

@pcbailey pcbailey Awaiting requested review from pcbailey

Assignees

@glekner glekner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yaacov @openshift-ci-robot @glekner @openshift-cherrypick-robot @spadgett @openshift-merge-robot