Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "add react-refresh hot reloading" #5640

Merged
merged 1 commit into from Jun 2, 2020

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Jun 1, 2020

Reverts #5246

Reverting for now as this breaks the topology page and causes other errors in development mode.

/assign @christianvogt @glekner

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2020
@andrewballantyne
Copy link
Contributor

@spadgett conflict. I suspect this is going to be annoying with any number of dependency overlaps.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2020
@spadgett spadgett force-pushed the revert-5246-react-refresh-lite branch from e3292f2 to 15c286b Compare June 2, 2020 12:53
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2020
@spadgett
Copy link
Member Author

spadgett commented Jun 2, 2020

Rebased

@andrewballantyne
Copy link
Contributor

/retest

1 similar comment
@spadgett
Copy link
Member Author

spadgett commented Jun 2, 2020

/retest

@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 00e60c8 into master Jun 2, 2020
@spadgett spadgett deleted the revert-5246-react-refresh-lite branch June 3, 2020 21:21
@spadgett spadgett added this to the v4.6 milestone Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants