Allow extensions to plugin to topology view #5647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
component/dev-console
rawagner
reviewed
Jun 3, 2020
| @@ -101,6 +103,10 @@ export class ExtensionRegistry { | |||
| return this.extensions.filter(isOverviewCRD); | |||
| } | |||
|
|
|||
| public getOverviewResourceUtils() { | |||
There was a problem hiding this comment.
registry is deprecated. Please use withExtensions HOC or useExtension hook
jeff-phillips-18
force-pushed
the
plugin-topology
branch
from
16d5fe3
to
3806b2a
Compare
openshift-ci-robot
added
the
needs-rebase
jeff-phillips-18
force-pushed
the
plugin-topology
branch
from
3806b2a
to
e21eaf4
Compare
openshift-ci-robot
removed
the
needs-rebase
jeff-phillips-18
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
jeff-phillips-18
force-pushed
the
plugin-topology
branch
4 times, most recently
from
ef2143a
to
2eaa2f3
Compare
|
Hit a blank screen when I loaded Jai's serverless test ns: I think he uses a setup script: |
jeff-phillips-18
force-pushed
the
plugin-topology
branch
from
2eaa2f3
to
c08cb31
Compare
Fixed, thanks. |
Move plugin resource utils to its own extension type, cleanup resourceUtils Use plugins for data model transforms Add plugin for creation of connectors Remove conversion of transform data to model, Update to use DataModelProvider Use extensions for filtering and getting display filters
jeff-phillips-18
force-pushed
the
plugin-topology
branch
from
c08cb31
to
8f5f212
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to plugin to the topology view.
Adds plugin capabilities for:
Holding for a future PR: