New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1810046: Show CSV icon from default channel #5650
Conversation
@spadgett: This pull request references Bugzilla bug 1810046, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We were always showing the icon from the first CSV channel in OperatorHub. We should prefer the icon from the `defaultChannel` when specified.
@spadgett: This pull request references Bugzilla bug 1810046, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I pulled the lazy-load change into a separate PR, #5677. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit.
/approve
/lgtm
resourceVersion: [pkg.metadata.name, defaultChannel.name, defaultChannel.currentCSV].join( | ||
'.', | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, should we just use a string template here?
resourceVersion: [pkg.metadata.name, defaultChannel.name, defaultChannel.currentCSV].join( | |
'.', | |
), | |
resourceVersion: `${pkg.metadata.name}.${defaultChannel.name}.${defaultChannel.currentCSV}`, |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.5 |
@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@spadgett: All pull requests linked via external trackers have merged: openshift/console#5650. Bugzilla bug 1810046 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@spadgett: new pull request created: #5685 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We were always showing the icon from the first CSV channel in OperatorHub.
We should prefer the icon from the
defaultChannel
when specified./assign @TheRealJon