Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1842857: Only show Edit Grouping action for VMs in topology view #5654

Merged
merged 1 commit into from Jun 3, 2020
Merged

Bug 1842857: Only show Edit Grouping action for VMs in topology view #5654

merged 1 commit into from Jun 3, 2020

Conversation

jeff-phillips-18
Copy link
Member

Analysis / Root cause:
The Edit Application Grouping kebab action was added to the list of vm-actions used for all VM kebabs.

Solution Description:
Remove the action from the list of vm-actions. Add the action to the VM actions used in the side panel and context menu in topology.

/kind bug

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. labels Jun 2, 2020
@openshift-ci-robot
Copy link
Contributor

@jeff-phillips-18: This pull request references Bugzilla bug 1842857, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1842857: Only show Edit Grouping action for VMs in topology view

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin labels Jun 2, 2020
@jeff-phillips-18
Copy link
Member Author

/cherry-pick release-4.5

@openshift-cherrypick-robot
Copy link

@jeff-phillips-18: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yaacov
Copy link
Member

yaacov commented Jun 2, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-phillips-18, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 2, 2020
@jeff-phillips-18
Copy link
Member Author

/retest

@yaacov
Copy link
Member

yaacov commented Jun 3, 2020

/test images

@openshift-merge-robot openshift-merge-robot merged commit 2025dfc into openshift:master Jun 3, 2020
@openshift-ci-robot
Copy link
Contributor

@jeff-phillips-18: All pull requests linked via external trackers have merged: openshift/console#5654. Bugzilla bug 1842857 has been moved to the MODIFIED state.

In response to this:

Bug 1842857: Only show Edit Grouping action for VMs in topology view

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 3, 2020
Merged
@openshift-cherrypick-robot
Copy link

@jeff-phillips-18: new pull request created: #5662

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Jun 15, 2020
@jeff-phillips-18 jeff-phillips-18 deleted the vm-actions branch December 2, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atiratree atiratree Awaiting requested review from atiratree

@yaacov yaacov Awaiting requested review from yaacov

Assignees

@yaacov yaacov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jeff-phillips-18 @openshift-ci-robot @openshift-cherrypick-robot @yaacov @spadgett @openshift-merge-robot