Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pipeline-bars): Pipeline cancelled show cancelled tasks as pending #5659

Merged
merged 1 commit into from Jun 11, 2020
Merged

fix(pipeline-bars): Pipeline cancelled show cancelled tasks as pending #5659

merged 1 commit into from Jun 11, 2020

Conversation

abhinandan13jan
Copy link
Contributor

Fixes:

https://issues.redhat.com/browse/ODC-4081

Analysis / Root cause:

Pipeline bars show Pending tasks for cancelled pipelines

Solution Description:

Pipeline bars updated with PipelineRun status check for showing cancelled

Screenshot

Screenshot from 2020-06-03 17-02-16

Browser conformation

Chrome 73

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Jun 3, 2020
@abhinandan13jan abhinandan13jan changed the title Pipeline cancelled [WIP] Pipeline cancelled Jun 3, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2020
@abhinandan13jan
Copy link
Contributor Author

/retest

@abhinandan13jan abhinandan13jan changed the title [WIP] Pipeline cancelled fix(pipeline-bars): Pipeline cancelled show cancelled tasks as pending Jun 4, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2020
andrewballantyne
andrewballantyne suggested changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You fixed a bug and the test didn't need to be fixed? I think we need to make sure you write a test that fails on the previous state and passes after this change to make sure we are catching this scenario correctly.

frontend/packages/dev-console/src/utils/pipeline-augment.ts Outdated Show resolved Hide resolved
andrewballantyne
andrewballantyne approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinandan13jan, andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2020
@openshift-merge-robot openshift-merge-robot merged commit e1415ba into openshift:master Jun 11, 2020
@spadgett spadgett added this to the v4.6 milestone Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03

Assignees

@andrewballantyne andrewballantyne

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@abhinandan13jan @openshift-ci-robot @andrewballantyne @spadgett @openshift-merge-robot