New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] CONSOLE-2152: - Improve upgrade messaging on the cluster settings page #5664
[WIP] CONSOLE-2152: - Improve upgrade messaging on the cluster settings page #5664
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cyril-ui-developer The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7b961b9
to
6b8a0ee
Compare
/retest |
6b8a0ee
to
ea1bbba
Compare
ea1bbba
to
d831be4
Compare
@cyril-ui-developer: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@cyril-ui-developer: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@cyril-ui-developer: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Obsolete |
/assign @TheRealJon
/cc @benjaminapetersen @spadgett
NB: I started a new conversation with Brie and Ben to find out if we want to show the Not upgradeable alert modal always in cluster setting and cluster operator pages because that was my previously understanding from the conversation I had with Brie. However I was concerned because this behavior is different from what is implemented in About modal. Based on the communication I had with Brie today , It seems we want to show the alert model when both a z-stream update AND non-upgradeable operators are available. Waiting on Ben take on this.
Although I don't know how to get z-stream update property yet.