Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] CONSOLE-2152: - Improve upgrade messaging on the cluster settings page #5664

Conversation

cyril-ui-developer
Copy link
Contributor

@cyril-ui-developer cyril-ui-developer commented Jun 3, 2020

/assign @TheRealJon
/cc @benjaminapetersen @spadgett

NB: I started a new conversation with Brie and Ben to find out if we want to show the Not upgradeable alert modal always in cluster setting and cluster operator pages because that was my previously understanding from the conversation I had with Brie. However I was concerned because this behavior is different from what is implemented in About modal. Based on the communication I had with Brie today , It seems we want to show the alert model when both a z-stream update AND non-upgradeable operators are available. Waiting on Ben take on this.

Although I don't know how to get z-stream update property yet.

Screen Shot 2020-06-03 at 8 44 06 AM

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cyril-ui-developer
To complete the pull request process, please assign bparees
You can assign the PR to them by writing /assign @bparees in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jun 3, 2020
@cyril-ui-developer cyril-ui-developer changed the title [WIP] CONSOLE-2152 - Improve upgrade messaging on the cluster settings page CONSOLE-2152 - Improve upgrade messaging on the cluster settings page Jun 3, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2020
@cyril-ui-developer cyril-ui-developer changed the title CONSOLE-2152 - Improve upgrade messaging on the cluster settings page CONSOLE-2152: - Improve upgrade messaging on the cluster settings page Jun 3, 2020
@cyril-ui-developer
Copy link
Contributor Author

cyril-ui-developer commented Jun 3, 2020

/retest

@cyril-ui-developer cyril-ui-developer changed the title CONSOLE-2152: - Improve upgrade messaging on the cluster settings page [WCONSOLE-2152: - Improve upgrade messaging on the cluster settings page Jun 5, 2020
@cyril-ui-developer cyril-ui-developer changed the title [WCONSOLE-2152: - Improve upgrade messaging on the cluster settings page [WIP] CONSOLE-2152: - Improve upgrade messaging on the cluster settings page Jun 5, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2020
@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/kubevirt-plugin d831be4 link /test kubevirt-plugin

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2020

@cyril-ui-developer: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/kubevirt-plugin d831be4 link /test kubevirt-plugin

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cyril-ui-developer
Copy link
Contributor Author

Obsolete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants