New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1843780: Dont wait for vm imports when listing vms #5670
Bug 1843780: Dont wait for vm imports when listing vms #5670
Conversation
@yaacov: This pull request references Bugzilla bug 1843780, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@suomiy please review do you think need to propagate the error to the user ? |
I suppose we should show the error. We could use an alert for that. |
@@ -252,18 +252,8 @@ const VirtualMachinesPage: React.FC<VirtualMachinesPageProps> = (props) => { | |||
const loadedMigrations = getLoadedData(migrations); | |||
const loadedVMImports = getLoadedData(vmImports); | |||
const loadedDataVolumes = getLoadedData(dataVolumes); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about?
const isVMImportLoaded = !vmImports || vmImports.loaded || vmImports.loadError; // go in when CRD missing or no permissions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
cb9f716
to
2315dbf
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: suomiy, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@yaacov: This pull request references Bugzilla bug 1843780, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-gcp-console |
/retest Please review the full test history for this PR and help us cut down flakes. |
@yaacov: All pull requests linked via external trackers have merged: openshift/console#5670. Bugzilla bug 1843780 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.5 |
@yaacov: new pull request created: #5672 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue
virtualmachineimports may not load because of errors, but we do not want to stop the vm list rendering.
Note:
Should show errors again once the permissions are setup correctly in vm-import-operator
p.s.
if the
Forbidden
error is not expected, we may want to catch the error and expose it to the user.