Bug 1844347: Align kubevirt tests with ux changes, fix teardown in environment tests #5675

rhrazdil · 2020-06-05T07:05:08Z

in disk modal, selection of SC that allows RWM automatically opens Advanced options, so we need to make sure we don't close it when selecting these
increasing timeouts for flaking vm environment expect script
simplified rdp console scenario, reduced the memory size to 1Gi so small clusters can run the test

openshift-ci-robot · 2020-06-05T07:33:58Z

@rhrazdil: This pull request references Bugzilla bug 1844347, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1844347: Align kubevirt tests with ux changes, fix teardown in environment tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yaacov · 2020-06-07T05:59:12Z

/bugzilla refresh

openshift-ci-robot · 2020-06-07T05:59:15Z

@yaacov: This pull request references Bugzilla bug 1844347, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gouyang · 2020-06-08T12:08:45Z

frontend/packages/kubevirt-plugin/integration-tests/tests/vm.non-admin.scenario.ts

@@ -62,13 +63,6 @@ describe('Kubevirt non-admin Flow', () => {
  it(
    'ID(CNV-1718) non-admin create project and create/remove vm',


Since create project is moved to beforeAll, the test name need to update accordingly.

updated the name

rhrazdil · 2020-06-09T12:07:14Z

@yaacov Could you review please?

yaacov · 2020-06-09T12:15:19Z

frontend/packages/kubevirt-plugin/integration-tests/tests/vm.non-admin.scenario.ts

@@ -60,15 +61,8 @@ describe('Kubevirt non-admin Flow', () => {
  });

  it(
-    'ID(CNV-1718) non-admin create project and create/remove vm',
+    'ID(CNV-1718) non-admin create create and remove a vm',


oh create create 🤦 ....

yaacov · 2020-06-09T12:17:13Z

/lgtm

gouyang · 2020-06-09T12:27:36Z

frontend/packages/kubevirt-plugin/integration-tests/tests/vm.detail.flavor.scenario.ts

-      const vm = await wizard.createVirtualMachine(
-        vmConfig(configName.toLowerCase(), testName, provisionConfig),
-      );
+      const vm = await wizard.createVirtualMachine(vm1Config);


Should we use createResource(testVM) here? Other tests vm.detail.* are using it.

I would keep the VM generated in the Wizard for the sake of being sure the VM labels have correct format.

yaacov · 2020-06-09T12:35:22Z

/lgtm cancel

will re-lgmt when fixed :-)

yaacov · 2020-06-09T13:34:18Z

/lgtm

openshift-ci-robot · 2020-06-09T13:34:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhrazdil, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/kubevirt-plugin/OWNERS~~ [rhrazdil,yaacov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yaacov · 2020-06-09T18:12:12Z

/test e2e-gcp-console

openshift-ci-robot · 2020-06-09T21:19:03Z

@rhrazdil: All pull requests linked via external trackers have merged: openshift/console#5675. Bugzilla bug 1844347 has been moved to the MODIFIED state.

In response to this:

Bug 1844347: Align kubevirt tests with ux changes, fix teardown in environment tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhrazdil · 2020-06-10T06:17:33Z

/cherry-pick release-4.5

openshift-cherrypick-robot · 2020-06-10T06:17:49Z

@rhrazdil: new pull request created: #5708

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from jelkosz and yaacov June 5, 2020 07:05

openshift-ci-robot added component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 5, 2020

rhrazdil changed the title ~~Align kubevirt tests with ux changes, fix teardown in environment tests~~ Bug 1844347: Align kubevirt tests with ux changes, fix teardown in environment tests Jun 5, 2020

openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Jun 5, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 5, 2020

openshift-ci-robot removed the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Jun 7, 2020

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 7, 2020

gouyang reviewed Jun 8, 2020

View reviewed changes

rhrazdil force-pushed the rhrazdil-4.5-ux-fixes branch from e2ba8ff to b83246e Compare June 9, 2020 11:12

yaacov reviewed Jun 9, 2020

View reviewed changes

openshift-ci-robot assigned yaacov Jun 9, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2020

gouyang reviewed Jun 9, 2020

View reviewed changes

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2020

Align kubevirt tests with ux changes, fix teardown in environment tests

e08b9e0

rhrazdil force-pushed the rhrazdil-4.5-ux-fixes branch from b83246e to e08b9e0 Compare June 9, 2020 13:23

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2020

openshift-merge-robot merged commit ef8f3ae into openshift:master Jun 9, 2020

openshift-cherrypick-robot mentioned this pull request Jun 10, 2020

[release-4.5.z] Bug 1845805: Align kubevirt tests with ux changes, fix teardown in environment tests #5708

Closed

spadgett added this to the v4.6 milestone Jun 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1844347: Align kubevirt tests with ux changes, fix teardown in environment tests #5675

Bug 1844347: Align kubevirt tests with ux changes, fix teardown in environment tests #5675

rhrazdil commented Jun 5, 2020

openshift-ci-robot commented Jun 5, 2020

yaacov commented Jun 7, 2020

openshift-ci-robot commented Jun 7, 2020

gouyang Jun 8, 2020

rhrazdil Jun 9, 2020

rhrazdil commented Jun 9, 2020

yaacov Jun 9, 2020

rhrazdil Jun 9, 2020

yaacov Jun 9, 2020

yaacov commented Jun 9, 2020

gouyang Jun 9, 2020

rhrazdil Jun 9, 2020

yaacov commented Jun 9, 2020

yaacov commented Jun 9, 2020

openshift-ci-robot commented Jun 9, 2020

yaacov commented Jun 9, 2020

openshift-ci-robot commented Jun 9, 2020

rhrazdil commented Jun 10, 2020

openshift-cherrypick-robot commented Jun 10, 2020

		@@ -62,13 +63,6 @@ describe('Kubevirt non-admin Flow', () => {
		it(
		'ID(CNV-1718) non-admin create project and create/remove vm',

Bug 1844347: Align kubevirt tests with ux changes, fix teardown in environment tests #5675

Bug 1844347: Align kubevirt tests with ux changes, fix teardown in environment tests #5675

Conversation

rhrazdil commented Jun 5, 2020

openshift-ci-robot commented Jun 5, 2020

yaacov commented Jun 7, 2020

openshift-ci-robot commented Jun 7, 2020

gouyang Jun 8, 2020

Choose a reason for hiding this comment

rhrazdil Jun 9, 2020

Choose a reason for hiding this comment

rhrazdil commented Jun 9, 2020

yaacov Jun 9, 2020

Choose a reason for hiding this comment

rhrazdil Jun 9, 2020

Choose a reason for hiding this comment

yaacov Jun 9, 2020

Choose a reason for hiding this comment

yaacov commented Jun 9, 2020

gouyang Jun 9, 2020

Choose a reason for hiding this comment

rhrazdil Jun 9, 2020

Choose a reason for hiding this comment

yaacov commented Jun 9, 2020

yaacov commented Jun 9, 2020

openshift-ci-robot commented Jun 9, 2020

yaacov commented Jun 9, 2020

openshift-ci-robot commented Jun 9, 2020

rhrazdil commented Jun 10, 2020

openshift-cherrypick-robot commented Jun 10, 2020