Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a test suite for kubevirt plugin #5686

Merged

Conversation

irosenzw
Copy link
Contributor

@irosenzw irosenzw commented Jun 7, 2020

Signed-off-by: Ido Rosenzwig irosenzw@redhat.com

@@ -71,6 +71,9 @@ const testSuites = {
'../packages/operator-lifecycle-manager/integration-tests/scenarios/global-installmode.scenario.ts',
'../packages/operator-lifecycle-manager/integration-tests/scenarios/single-installmode.scenario.ts',
]),
kubevirtPlugin: suite([
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can put this in our plugin kubevirt-plugin package.json, for example as kubevirt-gating

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

test-suites.sh Outdated
@@ -0,0 +1,13 @@
#!/usr/bin/env bash
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably call the test-gui script, shouldn't it?
But do we need to run multiple suites? I thought that the idea was to add a new job running single suite.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't run multiple suites - we need to run only kubevirt-gating suite in addition to the other tests that run regularly in each PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@irosenzw irosenzw force-pushed the add-kubevirt-test-suite branch 3 times, most recently from 438ec07 to 47691f7 Compare June 8, 2020 12:15
Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com>
@rhrazdil
Copy link

rhrazdil commented Jun 8, 2020

looks good
/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irosenzw, rhrazdil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 8, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0755fb4 into openshift:master Jun 8, 2020
@spadgett spadgett added this to the v4.6 milestone Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants