New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a test suite for kubevirt plugin #5686
Create a test suite for kubevirt plugin #5686
Conversation
6fa0c09
to
a007f03
Compare
@@ -71,6 +71,9 @@ const testSuites = { | |||
'../packages/operator-lifecycle-manager/integration-tests/scenarios/global-installmode.scenario.ts', | |||
'../packages/operator-lifecycle-manager/integration-tests/scenarios/single-installmode.scenario.ts', | |||
]), | |||
kubevirtPlugin: suite([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can put this in our plugin kubevirt-plugin package.json, for example as kubevirt-gating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
test-suites.sh
Outdated
@@ -0,0 +1,13 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably call the test-gui script, shouldn't it?
But do we need to run multiple suites? I thought that the idea was to add a new job running single suite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't run multiple suites - we need to run only kubevirt-gating suite in addition to the other tests that run regularly in each PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
438ec07
to
47691f7
Compare
Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com>
47691f7
to
34d45eb
Compare
looks good |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irosenzw, rhrazdil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Signed-off-by: Ido Rosenzwig irosenzw@redhat.com