Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1845769: Rename test name and add more categories #5707

Merged
merged 1 commit into from Jun 11, 2020
Merged

Bug 1845769: Rename test name and add more categories #5707

merged 1 commit into from Jun 11, 2020

Conversation

gouyang
Copy link
Contributor

@gouyang gouyang commented Jun 10, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 10, 2020
@openshift-ci-robot
Copy link
Contributor

@gouyang: This pull request references Bugzilla bug 1845769, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1845769: Rename test name and add more categories

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 10, 2020
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 10, 2020
@openshift-ci-robot
Copy link
Contributor

Hi @gouyang. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gouyang
Copy link
Contributor Author

gouyang commented Jun 10, 2020

/assign @rhrazdil

rhrazdil
rhrazdil reviewed Jun 10, 2020
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/tests/vm.detail.cdrom.scenario.ts
@@ -74,9 +58,6 @@ describe('KubeVirt VM detail - edit cdroms', () => {
await browser.wait(until.presenceOf(editCdView.diskSummary));

await vm.modalEditCDRoms();
await element
.all(by.css(editCdView.cdEjectBtn))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not required to eject the cdroms first?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no eject any more, just delete is there.

@rhrazdil
Copy link

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 11, 2020
@rhrazdil
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gouyang, rhrazdil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2020
@openshift-merge-robot openshift-merge-robot merged commit a924a52 into openshift:master Jun 11, 2020
@openshift-ci-robot
Copy link
Contributor

@gouyang: All pull requests linked via external trackers have merged: openshift/console#5707. Bugzilla bug 1845769 has been moved to the MODIFIED state.

In response to this:

Bug 1845769: Rename test name and add more categories

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Jun 15, 2020
@gouyang gouyang deleted the rename_files branch June 17, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhrazdil rhrazdil rhrazdil left review comments

@mareklibra mareklibra Awaiting requested review from mareklibra

@pcbailey pcbailey Awaiting requested review from pcbailey

Assignees

@rhrazdil rhrazdil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gouyang @openshift-ci-robot @rhrazdil @spadgett @openshift-merge-robot @wulax