Add guest agent info to vm resource summary #5711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
yaacov
force-pushed
the
guest-agent-data-in-vm-resource-summary
branch
3 times, most recently
from
b028b65
to
76f1e85
Compare
|
@pcbailey please review |
pcbailey
reviewed
Jun 11, 2020
| import { getVMIApiPath, getVMISubresourcePath } from '../selectors/vmi/selectors'; | ||
| import { isGuestAgentInstalled } from '../components/dashboards-page/vm-dashboard/vm-alerts'; | ||
|
|
||
| const guestAgentURL = (vmi: VMIKind) => |
There was a problem hiding this comment.
nitpick: Can we change this to getGuestAgentURL?
|
/lgtm |
yaacov
force-pushed
the
guest-agent-data-in-vm-resource-summary
branch
from
76f1e85
to
cf6b25b
Compare
yaacov
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
yaacov
force-pushed
the
guest-agent-data-in-vm-resource-summary
branch
2 times, most recently
from
44aa887
to
766960c
Compare
|
/test frontend |
pcbailey
reviewed
Jun 11, 2020
| @@ -78,11 +81,24 @@ export const VMDetails: React.FC<VMDetailsProps> = (props) => { | |||
| const vmiLike = kindObj === VirtualMachineModel ? vm : vmi; | |||
| const vmServicesData = getServicesForVmi(getLoadedData(props.services, []), vmi); | |||
| const canUpdate = useAccessReview(asAccessReview(kindObj, vmiLike || {}, 'patch')) && !!vmiLike; | |||
| const [guestAgentInfo] = useGuestAgentInfo({ vmi }); | |||
|
|
|||
| const OSMismatch = | |||
There was a problem hiding this comment.
nitpick: Can we call this OSMismatchExists?
| const OSMismatch = | ||
| vmi && guestAgentInfo && isWindows(vmiLike) !== (guestAgentInfo?.os?.id === 'mswindows'); | ||
| const OSMismatchAlert = OSMismatch && ( | ||
| <Alert className="co-alert" variant="warning" title="Operating syatem mismatch" isInline> |
There was a problem hiding this comment.
There's a typo in the title: syatem => system
| <Alert className="co-alert" variant="warning" title="Operating syatem mismatch" isInline> | ||
| The operating system defined for this virtual machine does not match what is being reported by | ||
| the Guest Agent. In order to correct this, you need to re-create the virtual machine with the | ||
| currect VM selection. The disks of this virtual machine and be attached to the newly created |
There was a problem hiding this comment.
Typo: currect => correct
I think what you're trying to say in the last sentence is "The disks of this virtual machine can be attached to the newly created one.", right?
yaacov
force-pushed
the
guest-agent-data-in-vm-resource-summary
branch
from
766960c
to
980809b
Compare
yaacov
force-pushed
the
guest-agent-data-in-vm-resource-summary
branch
from
980809b
to
9587148
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pcbailey, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add guest agent info to vm resource summary
Design: http://openshift.github.io/openshift-origin-design/designs/virtualization/4.x/expose-guest-data/expose%20guest%20data.html
Notes:
supported os types - https://github.com/kubevirt/common-templates#templates
downstream struct - https://www.qemu.org/docs/master/qemu-ga-ref.html#index-GuestOSInfo
Screenshot:
Add hostname, timezone and os name:
Add alert on OS mismatch:
OS name from GA and from YAML:
