fix Import Wizard flow #5715
fix Import Wizard flow #5715
Conversation
openshift-ci-robot
added
the
approved
| async waitForVMWarePod() { | ||
| await browser.wait(until.invisibilityOf(view.vmwarePodStatusLoader), POD_CREATION_TIMEOUT_SECS); | ||
| } | ||
| async waitForSpinner() { |
There was a problem hiding this comment.
can you please explain this function a bit?
There was a problem hiding this comment.
@suomiy Added doc string.
The problem with the loading spinner icon is that when user selects a VM from the list, the loading spinner disappears and re-appears at least one time during the load.
And if we attempt to click next during that period, we get an error.
There was a problem hiding this comment.
I see, if it works, then okay.
Shouldn't we also throw an exception / fail for the invalid path in case the spinner never stop spinning. We could wait for example for few minutes, so it doesn't become an infinite loop.
There was a problem hiding this comment.
Yes, that is good point, added limit of attempts.
rhrazdil
force-pushed
the
fix-import-wizard
branch
2 times, most recently
from
d6d6b15
to
1a5cb75
Compare
rhrazdil
force-pushed
the
fix-import-wizard
branch
from
1a5cb75
to
87822a1
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhrazdil, suomiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix spinner selector
Fix waiting for vm data to load in import Wizard
Fix final submit button selector