Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knative Gherkin features - Design [ODC-4112] #5717

Merged
merged 2 commits into from Jun 12, 2020
Merged

Knative Gherkin features - Design [ODC-4112] #5717

merged 2 commits into from Jun 12, 2020

Conversation

makambalaji
Copy link
Contributor

@makambalaji makambalaji commented Jun 10, 2020

Designed Gherkin feature files for Knative smoke test scenarios [ODC-4112] as per the doc

Create, Edit, Delete Kantive Service
Create, Edit, Delete Kantive Revision
Event Sources
Actions on Event sources

Note : All gherkin scenarios are appended with test case number present in doc

…couple of regression scenarios

Please enter the commit message for your changes. Lines starting
@makambalaji
Copy link
Contributor Author

/assign @andrewballantyne @sanketpathak @gajanan194 @christianvogt

@christianvogt
Copy link
Contributor

@makambalaji any particular reason for having this in the root instead of within the packages?

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Jun 11, 2020
@makambalaji
Copy link
Contributor Author

@makambalaji any particular reason for having this in the root instead of within the packages?

@christianvogt - Somehow got misplaced , moved the feature files to packages.. Thanks

@makambalaji makambalaji changed the title Design the gherkin scenarios for serverless smoke test scenarios and … Knative Gherkin features - Design [ODC-4112] Jun 11, 2020
@spadgett spadgett removed their request for review June 11, 2020 15:05
@christianvogt
Copy link
Contributor

/approve

anyone can review the scripts for accuracy

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2020
@gajanan-more
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, gajanan194, makambalaji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c882a73 into openshift:master Jun 12, 2020
@spadgett spadgett added this to the v4.6 milestone Jun 15, 2020
@makambalaji makambalaji deleted the ODC-4112-knative-smoke-test-scenarios branch September 3, 2020 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants