add support to select chart version in the helm install form #5718
Conversation
openshift-ci-robot
added
component/dev-console
| }) => { | ||
| const { chartName, chartVersion } = values; | ||
| const handleYAMLChange = () => { |
There was a problem hiding this comment.
This is getting called on every keystroke of user in the yaml editor which is not required. Better to have a check using initialValues.
There was a problem hiding this comment.
There's also an issue with this approach where user changes something in YAML but reverts it back, it will still consider the YAML dirty while technically it's not dirty.
| <YAMLEditorField | ||
| name="chartValuesYAML" | ||
| onSave={handleSubmit} | ||
| onChange={() => handleYAMLChange()} |
There was a problem hiding this comment.
| onChange={() => handleYAMLChange()} | |
| onChange={handleYAMLChange} |
| @@ -179,6 +176,7 @@ const HelmInstallUpgradePage: React.FunctionComponent<HelmInstallUpgradePageProp | |||
| {(props) => ( | |||
| <HelmInstallUpgradeForm | |||
| {...props} | |||
| appVersion={appVersion} | |||
| chartHasValues={chartHasValues} | |||
| submitLabel={helmAction} | |||
There was a problem hiding this comment.
Better to just send helmAction instead. Using submitLabel in the other components like helmAction seems weird.
| onAccept(); | ||
| return Promise.resolve(); | ||
| }, | ||
| cancel: () => { |
There was a problem hiding this comment.
Why do you need to set any value on cancel?
There was a problem hiding this comment.
because, when I select an option from the dropdown the chartVersion is immediately set to the selected option and then the modal opens up. Now, if I cancel the modal the chart version is not reset to the initial version, which is why I had to manually reset it by setting the chartversion value to the initial version.
|
update tests pls, there is a failing suite |
debsmita1
force-pushed
the
helm-install-chart-version
branch
4 times, most recently
from
351f6a6
to
c214674
Compare
openshift-ci-robot
added
lgtm
|
/lgtm cancel Added lgtm to wrong PR. Need to verify this locally. |
openshift-ci-robot
removed
lgtm
| submitLabel={submitLabel} | ||
| disableSubmit={(chartVersion && !dirty) || status?.isSubmitting || !_.isEmpty(errors)} | ||
| submitLabel={helmAction} | ||
| disableSubmit={isSubmitDisabled} |
There was a problem hiding this comment.
The submit button is not getting disabled now while submitting the form.
debsmita1
force-pushed
the
helm-install-chart-version
branch
from
c214674
to
1229949
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debsmita1, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/kind feature |
openshift-ci-robot
added
the
kind/feature
JIRA story:
https://issues.redhat.com/browse/ODC-4086
Solution Description:
isYAMLDirtyinHelmInstallUpgradeFormDatato check if changes have been to the YAML editorChart Versiondropdown title now shows the chart version concatenated with the App versionChart Versiondropdown is disabled if there are no chart versions or only one chart version is presentGIF:
