Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Release Gherkin Scripts - [ODC-4108] #5727

Merged

Conversation

gajanan-more
Copy link
Contributor

@gajanan-more gajanan-more commented Jun 15, 2020

Fixes: https://issues.redhat.com/browse/ODC-4108

Problem: Gherkin Scripts Design for Helm Release

Solution: These are the gherkin scripts designed covering all the scenarios related to Helm Release.

@gajanan-more
Copy link
Contributor Author

/assign @makambalaji @sanketpathak

@makambalaji
Copy link
Contributor

makambalaji commented Jun 16, 2020

Acceptance criteria is not covered for the scenarios related to ODC-3022 and ODC-2993 epics

Please go through the UX design and update the scenarios accordingly

@gajanan-more
Copy link
Contributor Author

Acceptance criteria is not covered for the scenarios related to ODC-3022 and ODC-2993 epics

Please go through the UX design and update the scenarios accordingly

I didn't find any missed scenario by looking at the UX design. Can you please share the missed scenarios?

@gajanan-more gajanan-more changed the title Helm Release Gherkin Scripts - [ODC-3022] and [ODC-2993] Helm Release Gherkin Scripts - [ODC-3022] Jun 17, 2020
@gajanan-more gajanan-more changed the title Helm Release Gherkin Scripts - [ODC-3022] Helm Release Gherkin Scripts - [ODC-4108] Jun 17, 2020
@sanketpathak
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2020
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gajanan-more, rohitkrai03, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2020
@openshift-merge-robot openshift-merge-robot merged commit 7892c92 into openshift:master Jun 17, 2020
@spadgett spadgett added this to the v4.6 milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants