Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated approvers list for dev-console/integration-tests folder #5739

Merged
merged 1 commit into from Jun 17, 2020
Merged

Updated approvers list for dev-console/integration-tests folder #5739

merged 1 commit into from Jun 17, 2020

Conversation

makambalaji
Copy link
Contributor

As per the today's discussion in UI sync meeting, updated OWNERS doc in integration-tests folder by including "makambalaji" in approvers list

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Jun 15, 2020
@makambalaji makambalaji changed the title Include makambalaji as approver for dev-console/integration-tests folder Updated approvers list for dev-console/integration-tests folder Jun 15, 2020
andrewballantyne
andrewballantyne approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2020
@andrewballantyne
Copy link
Contributor

/lgtm cancel

@makambalaji Can you squash your commits? I just noticed this now after I approved. Once you squash anyone can give you a LGTM if I am busy.

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2020
@christianvogt
Copy link
Contributor

@makambalaji I suspect you're going to want an owners file in the knative-plugin/integration-tests as well?

@makambalaji
Copy link
Contributor Author

@makambalaji I suspect you're going to want an owners file in the knative-plugin/integration-tests as well?

Agreed, but it's not part of dev console right, So I doubt, whether I can ask approval for that folder or not

@christianvogt
Copy link
Contributor

The dev-console team maintains the knative-plugin

@makambalaji
Copy link
Contributor Author

The dev-console team maintains the knative-plugin

Ok, then I will add another commit to the same PR, along with squashing the commits

@openshift-ci-robot openshift-ci-robot added component/knative Related to knative-plugin needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. component/kubevirt Related to kubevirt-plugin and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2020
@makambalaji
Update owner for integration-tests folder
08ee63f 
update the owners list for knative-pluign/integration-tests
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 16, 2020
andrewballantyne
andrewballantyne approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, makambalaji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewballantyne
Copy link
Contributor

/retest

Somehow test failures when OWNERS files are added? 🤔 Gotta be a fluke

@andrewballantyne
Copy link
Contributor

/retest

Heh, different test failures now.

@andrewballantyne
Copy link
Contributor

/test e2e-gcp-console

No logs? Hmmm..... trying again

@openshift-merge-robot openshift-merge-robot merged commit e7398d4 into openshift:master Jun 17, 2020
@spadgett spadgett added this to the v4.6 milestone Jun 24, 2020
@makambalaji makambalaji deleted the update-owner-for-dev-console/integration-tests branch September 3, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianvogt christianvogt christianvogt left review comments

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@nemesis09 nemesis09 Awaiting requested review from nemesis09

Assignees

@andrewballantyne andrewballantyne

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@makambalaji @andrewballantyne @christianvogt @openshift-ci-robot @spadgett @openshift-merge-robot