New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove guest agent selectors #5743
Remove guest agent selectors #5743
Conversation
@pcbailey please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small comments (no changes necessary), but looks good! =)
/lgtm
vmi && | ||
guestAgentInfo && | ||
isWindows(vmiLike) !== (getGuestOSID(guestAgentInfoOS) === 'mswindows'); | ||
vmi && guestAgentInfoRaw && isWindows(vmiLike) !== (operatingSystemID === 'mswindows'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leave this here for now, but can add it to the GuestAgentOSInfoWrapper
if you want.
isNotAvail={!getGuestAgentInfoHostname(guestAgentInfo)} | ||
> | ||
{getGuestAgentInfoHostname(guestAgentInfo)} | ||
<VMDetailsItem title="Hostname" idValue={prefixedID(id, 'hostname')} isNotAvail={!hostname}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may change based on @matthewcarleton's input on #5741 (comment), but we'll go with this for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pcbailey, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Remove guest agaent selectors