Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design the gherkin scenarios for Add Flow smoke test suite [ODC-4106] #5775

Merged
merged 1 commit into from Jun 18, 2020
Merged

Design the gherkin scenarios for Add Flow smoke test suite [ODC-4106] #5775

merged 1 commit into from Jun 18, 2020

Conversation

makambalaji
Copy link
Contributor

@makambalaji makambalaji commented Jun 18, 2020 •
edited

Designed the gherkin scenarios for add flow - smoke test suite as per the doc
All scenario titles are appended with test case number to track the test cases are present as per the doc

@makambalaji
Design the gherkin scenarios for Add Flow smoke test suite
e6cabeb 
Designed the gherkin scenarios for Add Flow smoke test suite
@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Jun 18, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2020
@openshift-ci-robot
Copy link
Contributor

@makambalaji: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@makambalaji
Copy link
Contributor Author

/retest

2 similar comments
@makambalaji
Copy link
Contributor Author

/retest

@makambalaji
Copy link
Contributor Author

/retest

@makambalaji
Copy link
Contributor Author

/assign @andrewballantyne

@andrewballantyne
Copy link
Contributor

Due to merging issues with #5738 (comment), this PR was raised. Sanket already added a lgtm to that PR, just moving it here.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, makambalaji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5eb6777 into openshift:master Jun 18, 2020
@spadgett spadgett added this to the v4.6 milestone Jun 24, 2020
@makambalaji makambalaji deleted the odc-4106-add-flow-smoke-test-scenarios branch September 3, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gajanan-more gajanan-more Awaiting requested review from gajanan-more

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

Assignees

@andrewballantyne andrewballantyne

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@makambalaji @openshift-ci-robot @andrewballantyne @spadgett @openshift-merge-robot